Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stitch plan extension #640

Merged
merged 2 commits into from Mar 22, 2020
Merged

add stitch plan extension #640

merged 2 commits into from Mar 22, 2020

Conversation

kaalleen
Copy link
Collaborator

@kaalleen kaalleen commented Mar 19, 2020

Creates a stitch plan extension as proposed in #206

@lexelby
Copy link
Member

@lexelby lexelby commented Mar 20, 2020

Nice!!

The stitch plan isn't shifted over properly in my test:

stitch_plan_preview

@lexelby
Copy link
Member

@lexelby lexelby commented Mar 20, 2020

Oh, I know what's going on here. I might have the viewbox in my SVG set weirdly.

I think we can fix that and also make your code simpler. Instead of using unittouu, we should just be able to take the third number in the viewBox and use that as the translation amount. The viewBox is defined as "the size of the canvas in user units", which is exactly what we want.

@kaalleen
Copy link
Collaborator Author

@kaalleen kaalleen commented Mar 20, 2020

Hm, ok yes, that makes sense. Thanks for having a look into it.

@kaalleen
Copy link
Collaborator Author

@kaalleen kaalleen commented Mar 20, 2020

Are we going to remove the embroider extension in favor of the stitch plan extension?

@lexelby
Copy link
Member

@lexelby lexelby commented Mar 20, 2020

Hmm, what do you think?

We've had one or two bugs recently that made it so that File -> Save As didn't work. The workaround was to use Embroider instead.

There's also one thing Embroider can do that Save As can't do: you can set the "collapse length", which is really just the threshold for adding a JUMP instruction. I actually used that. I want to add a Document Settings thing for stuff like that. We do kind of have that in Print PDF but this setting would be a bit out of place there...

I think we should probably keep Embroider, but maybe have it just create machine embroidery files and not show the stitch plan? What do you think?

@kaalleen
Copy link
Collaborator Author

@kaalleen kaalleen commented Mar 21, 2020

I had those bugs in mind when I was asking the question. I still wanted to bring it up, because removing the embroider extension was our plan in above mentioned issue.
I would plead for leaving it alive and "as is" for now.

@lexelby
Copy link
Member

@lexelby lexelby commented Mar 21, 2020

I agree, let's leave it as is. I sort of have this vague idea of declaring version 2.0 sometime after we get everything converted over to Electron. Maybe then we can change how Embroider works :)

@kaalleen kaalleen merged commit 88ba830 into master Mar 22, 2020
4 checks passed
@kaalleen kaalleen deleted the stitch-plan-extension branch Mar 22, 2020
kaalleen added a commit that referenced this issue May 16, 2020
## New Features

- New Simulator (#531)
- Import Threadlist (#666)
- Export Threadlist in ZIP file (#664)
- Option to include SVG in ZIP file (#648)
- Break Apart and Retain Holes (#653)
- G-Code: option to alternate z-value (#659)
- New Stitch Plan Extension (#640)
- Optionally enable/disable ties (lock down stitches) (#619)
- Multiple Fill Underlays
- Additional Fonts (#683):
    * Geneva
    * DejaVu

## Improvements

- Better Algorithm for Satin Columns (#607)
- Better Algorithm for Fill Stitches (#606)
- Convert to Satin with Loops (#608)
- Adding '@ #' to all fonts (#680)

## Bug Fixes

- Fix Issue with Troubleshoot Pointer Position (#696)
- Inherit Styles (#673)
- Fix Color Palette Issues (#660)
- Preserve Aspect Ratio (#646)
- and more

## Under the Hood

- Namespaced Attributes (#657)
- Remove stub.py (#629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants