Build improvements for the inkscape1.0 branch #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilation takes ~30minutes otherwise)
kaalleen
requested changes
Jan 20, 2021
lexelby
reviewed
Jan 22, 2021
| @@ -525,7 +525,7 @@ def tab_sort_key(tab): | |||
|
|
|||
| # If multiple tabs are enabled, make sure dependent | |||
| # tabs are grouped with the parent. | |||
| parent, | |||
| parent and parent.name, | |||
There was a problem hiding this comment.
Hi! Thanks for your PR, we really appreciate your contribution.
What is this change about? Use it not working as just parent?
There was a problem hiding this comment.
Yes, this fixes the error mentioned in #980 (comment)
lexelby
reviewed
Jan 22, 2021
| key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-yarn- | ||
|
|
There was a problem hiding this comment.
Thank you for figuring this stuff out. I never did manage to find the time to figure out caching.
There was a problem hiding this comment.
Actually this is just copy and paste of the examples from https://github.com/actions/cache/blob/main/examples.md#node---yarn
But it does seem to work :)
rumpeltux
force-pushed
the
rumpeltux/inkscape1.0
branch
from
76c1d4b
to
736f295
Compare
kaalleen
pushed a commit
that referenced
this pull request
Jan 23, 2021
* Building for the current ubuntu LTS which will be the default soon. * Cache pip and yarn to accellerate repeated builds (e.g. wxPython compilation takes ~30minutes otherwise) * Cannot sort by ParamsTab. Use .name instead.
kaalleen
pushed a commit
that referenced
this pull request
Jan 30, 2021
* Building for the current ubuntu LTS which will be the default soon. * Cache pip and yarn to accellerate repeated builds (e.g. wxPython compilation takes ~30minutes otherwise) * Cannot sort by ParamsTab. Use .name instead.
kaalleen
pushed a commit
that referenced
this pull request
Feb 2, 2021
* Building for the current ubuntu LTS which will be the default soon. * Cache pip and yarn to accellerate repeated builds (e.g. wxPython compilation takes ~30minutes otherwise) * Cannot sort by ParamsTab. Use .name instead.
kaalleen
pushed a commit
that referenced
this pull request
Feb 4, 2021
* Building for the current ubuntu LTS which will be the default soon. * Cache pip and yarn to accellerate repeated builds (e.g. wxPython compilation takes ~30minutes otherwise) * Cannot sort by ParamsTab. Use .name instead.
kaalleen
pushed a commit
that referenced
this pull request
Feb 7, 2021
* Building for the current ubuntu LTS which will be the default soon. * Cache pip and yarn to accellerate repeated builds (e.g. wxPython compilation takes ~30minutes otherwise) * Cannot sort by ParamsTab. Use .name instead.
kaalleen
pushed a commit
that referenced
this pull request
Feb 28, 2021
* Building for the current ubuntu LTS which will be the default soon. * Cache pip and yarn to accellerate repeated builds (e.g. wxPython compilation takes ~30minutes otherwise) * Cannot sort by ParamsTab. Use .name instead.
kaalleen
added a commit
that referenced
this pull request
Mar 4, 2021
* update for inkscape 1.0 * add about extension * Build improvements for the inkscape1.0 branch (#985) * zip: export real svg not stitch plan * #411 and #726 * Tools for Font Creators (#1018) * ignore very small holes in fills * remove embroider (#1026) * auto_fill: ignore shrink_or_grow if result is empty (#589) * break apart: do not ignore small fills Co-authored-by: Hagen Fritsch <rumpeltux-github@irgendwo.org> Co-authored-by: Lex Neva <github.com@lexneva.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.