Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on object movement #32

Closed
dertseha opened this issue Aug 21, 2018 · 1 comment
Closed

Crash on object movement #32

dertseha opened this issue Aug 21, 2018 · 1 comment
Labels
bug
Milestone

Comments

@dertseha
Copy link
Member

@dertseha dertseha commented Aug 21, 2018

The following was reported:

I crashed hacked. I selected the two words in the starting area near the healing machine and clicked on "+" on tileY to move them both to another tile.
I crashed it again but this time I clicked on "-" of tileX to move it into the other direction.
I tried it with other object pairs, but it didnt worked. Could be related to the bug you fixed where objects are on either 0 or 255 of a tiles FineX/Y
I can reproduce the crash 100% of the time.
Even if I just move on of them it happens ¯\(ツ)

@dertseha dertseha added the bug label Aug 21, 2018
dertseha added a commit that referenced this issue Sep 1, 2018
If the proper end of the loop has been reached, then release object reference
@dertseha dertseha added this to the v1.1.0 milestone Sep 1, 2018
@dertseha

This comment has been minimized.

Copy link
Member Author

@dertseha dertseha commented Sep 1, 2018

found the issue.

It's funny that the re-implementation, with the help of the source release, has so many troubles, whereas the reverse-engineered variant was fine ...

@dertseha dertseha closed this Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.