Victor Julien
inliniac

Organizations

@OISF
Jul 15, 2016
inliniac commented on pull request inliniac/suricata#2177
@inliniac

@thus, any feedback on this one? Thanks!

Jul 15, 2016
inliniac commented on pull request inliniac/suricata#2179
@inliniac

Another dead lock, this time related to the flowvar handling: (gdb) bt #0 __lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:13…

Jul 13, 2016
inliniac commented on pull request inliniac/suricata#2044
@inliniac

@thus ping

Jul 13, 2016
inliniac closed pull request inliniac/suricata#1474
@inliniac
Bug 1231 - SSL State Negation - v3
Jul 13, 2016
inliniac commented on pull request inliniac/suricata#1474
@inliniac

Seems this was already replaced with #2044

Jul 13, 2016
inliniac closed pull request inliniac/suricata#2116
@inliniac
App layer stats v13
Jul 13, 2016
inliniac commented on pull request inliniac/suricata#1899
@inliniac

Not sure if that works. It seems the core license also uses an exception of some kind. IANAL so I prefer waiting for their MIT relicense :)

Jul 13, 2016
inliniac closed pull request inliniac/suricata#2031
@inliniac
Preview: DNP3 Support - v8
Jul 13, 2016
inliniac closed pull request inliniac/suricata#1223
@inliniac
optimization, buffer api: Reduce the size of the MemBuffer structure.
Jul 13, 2016
inliniac closed pull request inliniac/suricata#1136
@inliniac
tls pr1099 v1
Jul 13, 2016
inliniac commented on pull request inliniac/suricata#2123
@inliniac

whoops didn't mean to close just yet

Jul 13, 2016
inliniac reopened pull request inliniac/suricata#2123
@inliniac
Unix socket auto
2 commits with 42 additions and 11 deletions
Jul 13, 2016
inliniac closed pull request inliniac/suricata#2123
@inliniac
Unix socket auto
Jul 13, 2016
inliniac commented on pull request inliniac/suricata#2123
@inliniac

I've been thinking about whether this use of the Time API is a proper way to query the engine's run mode. I tend to think it may be better to handl…

Jul 13, 2016
inliniac commented on pull request inliniac/suricata#2175
@inliniac

Why would you want to disable this?

Jul 13, 2016
inliniac closed pull request inliniac/suricata#2044
@inliniac
Issue 1231 - SSL Negation - v4.1
Jul 13, 2016
inliniac commented on pull request inliniac/suricata#2044
@inliniac

I don't remember why I let this sit here. Could you rebase it?

Jul 13, 2016
inliniac closed pull request inliniac/suricata#1918
@inliniac
cuda: ensue that compile time conditionals pick up the cuda support definition.
Jul 13, 2016
inliniac closed pull request inliniac/suricata#1798
@inliniac
util-device: fix iface stats output
Jul 13, 2016
inliniac commented on pull request inliniac/suricata#1798
@inliniac

I'm still not convinced this is the way to go.

Jul 13, 2016
inliniac closed pull request inliniac/suricata#1738
@inliniac
Issue 1592: Fix deadlock in thread restart
Jul 13, 2016
inliniac commented on pull request inliniac/suricata#1738
@inliniac

Got a patch queued for 3.2 :)

Jul 13, 2016
inliniac commented on pull request inliniac/suricata#1738
@inliniac

I think I'm going to completely remove the restart logic. It never worked well and there are several components that would require complicated fixe…

Jul 13, 2016
inliniac commented on pull request inliniac/suricata#2099
@inliniac

I'm still a bit fuzzy on how the state and tx' work. The state seems to have a lock implying concurrent access. How does that affect transactions? …

Jul 13, 2016
inliniac commented on pull request inliniac/suricata#2099
@inliniac

can we used names instead of integers here?

Jul 13, 2016
inliniac commented on pull request inliniac/suricata#2099
@inliniac

if (input_len < DHCP_MIN_FRAME_LEN)\n goto end; would have the same effect, except the whole block after can move one step left. Much preferred for…

Jul 13, 2016
inliniac commented on pull request inliniac/suricata#2099
@inliniac

what is this CAS's purpose?

Jul 13, 2016
inliniac commented on pull request inliniac/suricata#2099
@inliniac

this belongs in a separate commit

Jul 13, 2016
inliniac closed pull request inliniac/suricata#1874
@inliniac
output-json-dns: dns output filtering.
Jul 13, 2016
inliniac commented on pull request inliniac/suricata#1874
@inliniac

Hoping for a new version of this :)