Skip to content

Commit

Permalink
Add tweaks to Incident Banner (#1368)
Browse files Browse the repository at this point in the history
* Add tweaks

* Change text color

* Update pnpm version

* Update package manager
  • Loading branch information
anafilipadealmeida committed May 17, 2024
1 parent 9ae81d6 commit 2b7288d
Show file tree
Hide file tree
Showing 12 changed files with 23 additions and 21 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/components_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
with:
version: "8.6.2"
version: "8.15.8"
- uses: actions/setup-node@v4
with:
node-version: "18"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v4
with:
version: 8.6.2
version: 8.15.8
- name: Build UI
run: make build-ui
- name: Build dev serve
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v4
with:
version: 8.6.2
version: 8.15.8
- name: Set sha
id: sha
run: echo "sha=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ui_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v2.4.0
with:
version: "8.6.2"
version: "8.15.8"
- uses: actions/setup-node@v3
with:
node-version: "18"
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"packageManager": "pnpm@8.6.2"
"packageManager": "pnpm@8.15.8"
}
2 changes: 1 addition & 1 deletion tests/js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "inngest-js-tests",
"version": "0.1.0",
"private": true,
"packageManager": "pnpm@8.6.2",
"packageManager": "pnpm@8.15.8",
"scripts": {
"dev": "next dev",
"build": "next build",
Expand Down
4 changes: 2 additions & 2 deletions ui/apps/dashboard/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@
},
"engines": {
"node": "18.x",
"pnpm": "8.6.2"
"pnpm": "8.15.8"
},
"packageManager": "pnpm@8.6.2",
"packageManager": "pnpm@8.15.8",
"private": true
}
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ export default function FilterEvents({ keyID, filter }: FilterEventsProps) {
return (
<form className="pt-3" onSubmit={handleSubmit}>
<h2 className="pb-1 text-lg font-semibold">Filter Events</h2>
<p className="text-sm text-slate-500">
<p className="text-sm text-slate-700">
Filtering allows you to specify allow or deny lists for event names and/or IP addresses.
</p>
<p className="text-sm text-slate-500">
<p className="text-sm text-slate-700">
Allowlists only allow specified values, whereas denylists allow all but the specified
values.
</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,13 @@ export default function IncidentBanner() {
const isIncidentBannerEnabled = useBooleanFlag('incident-banner');
const status = useSystemStatus();

if (!isIncidentBannerEnabled.value && status.indicator === 'none') return;
if (!isIncidentBannerEnabled.value) return;

let message = '';
let message = 'We are experiencing some issues.';
let severity: Severity = 'warning';

if (isIncidentBannerEnabled.value) {
message = ' We are experiencing some issues.';
} else {
message = `${status.description}`;
if (status.indicator !== 'none') {
message = `${status.description} -`;
if (status.indicator === 'minor') {
severity = 'info';
}
Expand All @@ -28,7 +26,7 @@ export default function IncidentBanner() {
<Banner kind={severity}>
{message} Please check the{' '}
<span style={{ display: 'inline-flex' }}>
<Link href="https://status.inngest.com/">status page.</Link>
<Link href="https://status.inngest.com/">status page</Link>
</span>
</Banner>
);
Expand Down
4 changes: 2 additions & 2 deletions ui/apps/dev-server-ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@
},
"engines": {
"node": "18.x",
"pnpm": "8.6.2"
"pnpm": "8.15.8"
},
"packageManager": "pnpm@8.6.2",
"packageManager": "pnpm@8.15.8",
"private": true
}
4 changes: 2 additions & 2 deletions ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
},
"engines": {
"node": "18.x",
"pnpm": "8.6.2"
"pnpm": "8.15.8"
},
"packageManager": "pnpm@8.6.2",
"packageManager": "pnpm@8.15.8",
"private": true
}
4 changes: 4 additions & 0 deletions ui/packages/components/src/AppRoot/globals.css
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,7 @@
:focus-visible {
outline-color: white;
}

.monaco-editor .overflow-guard {
@apply rounded-b-lg;
}

0 comments on commit 2b7288d

Please sign in to comment.