Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devserver: fix custom event IDs are not idempotent #1202

Merged
merged 3 commits into from
Feb 29, 2024
Merged

devserver: fix custom event IDs are not idempotent #1202

merged 3 commits into from
Feb 29, 2024

Conversation

goodoldneon
Copy link
Contributor

Description

Fix bug where a custom event.id was not treated as an idempotency key. If >1 events have the same id then only the first should trigger runs

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Check our Pull Request Guidelines

@vercel Vercel
Copy link

vercel bot commented Feb 29, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 8:47pm

@tonyhb tonyhb changed the title Fix custom event IDs are not idempotent devserver: fix custom event IDs are not idempotent Feb 29, 2024
tonyhb
tonyhb approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@tonyhb tonyhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add a test before merging plz

@goodoldneon goodoldneon merged commit dfc3e81 into main Feb 29, 2024
12 checks passed
@goodoldneon goodoldneon deleted the fix-event-idempotency-key branch February 29, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyhb tonyhb tonyhb approved these changes

@djfarrelly djfarrelly Awaiting requested review from djfarrelly djfarrelly is a code owner

@darwin67 darwin67 Awaiting requested review from darwin67 darwin67 is a code owner

@jpwilliams jpwilliams Awaiting requested review from jpwilliams jpwilliams is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@goodoldneon @tonyhb