Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INN-2843 Add Triggerable concept to OSS to help inngestgo with multi-trigger #1203

Merged
merged 1 commit into from
Mar 1, 2024
Merged

INN-2843 Add Triggerable concept to OSS to help inngestgo with multi-trigger #1203

merged 1 commit into from
Mar 1, 2024

Conversation

jpwilliams
Copy link
Member

@jpwilliams jpwilliams commented Feb 29, 2024 •
edited

Description

Adds the concept of a Triggerable, allowing us to specify either a single trigger or multiple triggers in inngest/inngestgo.

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Related

Check our Pull Request Guidelines

@jpwilliams jpwilliams added the go Pull requests that update Go code label Feb 29, 2024
@jpwilliams jpwilliams self-assigned this Feb 29, 2024
@linear Linear
Copy link

linear bot commented Feb 29, 2024

INN-2843 Add shared `Triggerable` to OSS

@vercel Vercel
Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
ui ⬜️ Ignored (Inspect) Feb 29, 2024 0:27am

@jpwilliams jpwilliams mentioned this pull request Feb 29, 2024
Merged
@jpwilliams jpwilliams merged commit 9baeb66 into main Mar 1, 2024
11 of 12 checks passed
@jpwilliams jpwilliams deleted the feat/multi-trigger-shared branch March 1, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyhb tonyhb tonyhb approved these changes

@djfarrelly djfarrelly Awaiting requested review from djfarrelly djfarrelly is a code owner

@darwin67 darwin67 Awaiting requested review from darwin67 darwin67 is a code owner

@goodoldneon goodoldneon Awaiting requested review from goodoldneon goodoldneon is a code owner

Assignees

@jpwilliams jpwilliams

Labels
go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpwilliams @tonyhb