Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render RunDetails inside row #1349

Merged

Conversation

anafilipadealmeida
Copy link
Contributor

Description

  • Render RunDetails inside the runs table
Screen.Recording.2024-05-13.at.01.27.52.mov

There are things that need to be added in a different PR (link to open in new tab, changing the loading from spinner to skeleton)

Motivation

Getting the run details already here helps figuring out loading and scrolling for the entire page

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Check our Pull Request Guidelines

Copy link

linear bot commented May 13, 2024

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 0:31am

@anafilipadealmeida anafilipadealmeida merged commit 2f4146d into main May 13, 2024
7 checks passed
@anafilipadealmeida anafilipadealmeida deleted the ana/inn-3041-render-rundetails-inside-runs-table branch May 13, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants