New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to delete posts #10

Closed
FND opened this Issue Nov 23, 2012 · 5 comments

Comments

Projects
None yet
3 participants
@FND
Member

FND commented Nov 23, 2012

users should be able to delete individual status messages in order to avoid Weiner incidents

@FND FND referenced this issue Mar 13, 2013

Closed

make posts editable #46

@aheusingfeld

This comment has been minimized.

Contributor

aheusingfeld commented Aug 5, 2013

If you don't mind, I'll use this task to get a little familiar with Clojure.

@stilkov

This comment has been minimized.

Contributor

stilkov commented Aug 6, 2013

Please do.

@aheusingfeld

This comment has been minimized.

Contributor

aheusingfeld commented Aug 6, 2013

Current status:
statuses-issues10-delete-button

Open question: What shall be done in case the post is part of a conversation?
Currently it's deleted nevertheless, leaving the data in an inconsistent state which leads to an Exception if the conversation is requested:

java.lang.IndexOutOfBoundsException
RT.java:784 clojure.lang.RT.nthFrom
RT.java:753 clojure.lang.RT.nth
utils.clj:52    clj-stacktrace.utils/quartile1
utils.clj:69    clj-stacktrace.utils/fence
repl.clj:98 clj-stacktrace.repl/find-source-width
repl.clj:107    clj-stacktrace.repl/pst-on
repl.clj:123    clj-stacktrace.repl/pst-str
RestFn.java:408 clojure.lang.RestFn.invoke
stacktrace.clj:17   ring.middleware.stacktrace/wrap-stacktrace-log[fn]
stacktrace.clj:79   ring.middleware.stacktrace/wrap-stacktrace-web[fn]
reload.clj:18   ring.middleware.reload/wrap-reload[fn]
jetty.clj:18    ring.adapter.jetty/proxy-handler[fn]
(Unknown Source)    ring.adapter.jetty.proxy$org.eclipse.jetty.server.handler.AbstractHandler$0.handle
HandlerWrapper.java:111 org.eclipse.jetty.server.handler.HandlerWrapper.handle
Server.java:349 org.eclipse.jetty.server.Server.handle
AbstractHttpConnection.java:452 org.eclipse.jetty.server.AbstractHttpConnection.handleRequest
AbstractHttpConnection.java:884 org.eclipse.jetty.server.AbstractHttpConnection.headerComplete
AbstractHttpConnection.java:938 org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete
HttpParser.java:634 org.eclipse.jetty.http.HttpParser.parseNext
HttpParser.java:230 org.eclipse.jetty.http.HttpParser.parseAvailable
AsyncHttpConnection.java:76 org.eclipse.jetty.server.AsyncHttpConnection.handle
SelectChannelEndPoint.java:609  org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle
SelectChannelEndPoint.java:45   org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run
QueuedThreadPool.java:599   org.eclipse.jetty.util.thread.QueuedThreadPool.runJob
QueuedThreadPool.java:534   org.eclipse.jetty.util.thread.QueuedThreadPool$3.run
Thread.java:724 java.lang.Thread.run

aheusingfeld added a commit to aheusingfeld/statuses that referenced this issue Aug 6, 2013

Fixed innoq#10
Introduced a 'trash' button to the ui which sends an HTTP DELETE request to the resource of the according post.
@stilkov

This comment has been minimized.

Contributor

stilkov commented Aug 6, 2013

I suggest to keep things easy and disallow deletion for posts with replies.

@aheusingfeld

This comment has been minimized.

Contributor

aheusingfeld commented Aug 6, 2013

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment