Do not import trombi in setup.py #20

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@truemped
Contributor
truemped commented May 4, 2011

This causes problems when using buildout, e.g. since there is no
globally installed Tornado version available. Then the "from trombi
import version" statement causes the buildout to fail!

Daniel Truemper Do not import trombi in setup.py
This causes problems when using buildout, e.g. since there is no
globally installed Tornado version available. Then the "from trombi
import version" statement causes the buildout to fail!
7a12114
@nailor
Member
nailor commented May 4, 2011

Hmm, this really is an issue. However, the solution is bit problematic: I'd like to keep a version that could be accessed from python (for example: from trombi import version), but due to the convenience imports in __init__.py this probably is impossible.

Thus I'm thinking of reverting back to describing version information in setup.py and abandoning the version in __init__.py as I'm not too confident adding magical file reading in setup.py which probably would break in future.

@truemped
Contributor
truemped commented May 5, 2011

Yes, that is a better solution. Should I do this in this pull request, or will you do this and we simply close this!?

@nailor
Member
nailor commented May 5, 2011

If it's not too much trouble, just change it in this and I'll merge as soon as possible. Thanks for your pull request beforehand :)

@truemped
Contributor
truemped commented May 5, 2011

Not at all! :)

Daniel

@nailor nailor added a commit that closed this pull request May 5, 2011
@nailor nailor Merge branch 'truemped-fix-version'
Fixes GH-20
7c51c93
@nailor nailor closed this in 7c51c93 May 5, 2011
@nailor
Member
nailor commented May 5, 2011

I made a minor changes to pull request: squashed the two commits together and reworded commit message a bit

@truemped
Contributor
truemped commented May 5, 2011

Perfect :) Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment