Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed but with changes() always timing out efter 20 seconds #36

Merged
merged 3 commits into from May 5, 2012

Conversation

Projects
None yet
2 participants
Contributor

bjorkegeek commented Apr 30, 2012

Increased tornado http timeout to 20 seconds more than couchdb timeout
when using feed=continuous with changes()

Member

nailor commented May 1, 2012

Thanks for the Pull Request!

Can you clarify what's the rational behind this?

@nailor nailor closed this May 4, 2012

Member

nailor commented May 4, 2012

I'm closing this pull request as I fail to see the rational of adding 20 second extra timeout. Feel free to comment here or open a new one, if you disagree.

Contributor

bjorkegeek commented May 5, 2012

Jyrki,

Tornado's HTTP client has a default timeout of 20 seconds for the entire
HTTP request.

change()-requests of type continuous are long running requests with a
special timeout variable passed to couchdb (see
http://wiki.apache.org/couchdb/HTTP_database_API#Changes ).

As I understood the current trombi code, it does not change the HTTP
timeout, essentially limiting all requests to 20 seconds. This was what
my patched attempted to change (changing the Tornado HTTP timeout to the
couch timeout + 20 extra seconds).

Perhaps I misunderstood something about how to use trombi in this case?

Regards,
David Björkevik

On 2012-05-05 00:58, Jyrki Pulliainen wrote:

I'm closing this pull request as I fail to see the rational of adding 20 second extra timeout. Feel free to comment here or open a new one, if you disagree.


Reply to this email directly or view it on GitHub:
#36 (comment)

@nailor nailor reopened this May 5, 2012

Member

nailor commented May 5, 2012

Ah, you're correct. For some unknown reason I seem to have accidentally removed that functionality in b850270.

I'm not too confident with extra 20 seconds, as that is a really long timeout, but maybe a smaller increment, 0.5 or so, would do the trick. The client timeout needs to be a bit smaller anyway for this to work.

Can you alter your commit to reduce the timeout and amend it, I'll merge it then :)

Contributor

bjorkegeek commented May 5, 2012

I think I've done that now. Let me know if something needs fixing, I'm a GitHub noob.

Member

nailor commented May 5, 2012

One tiny change: can you add yuorself to the AUTHORS file and I'll merge this :)

@nailor nailor added a commit that referenced this pull request May 5, 2012

@nailor nailor Merge pull request #36 from bjorkegeek/master
Fixes changes() always timing out after 20 seconds
f985d43

@nailor nailor merged commit f985d43 into inoi:master May 5, 2012

Member

nailor commented May 5, 2012

Merged! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment