feat(patch): remove double tap overlay

[tb115]

Application

YouTube

Issue

When double tapping to skip 10 seconds the video briefly darkens. Enabling 'remove player button background' does not remove the player background when double tapping to skip. Another patch can add in this feature. Thanks for considering.

Patch

Motivation

This patch will nicely compliment the 'remove player button background' patch. This will make the player experience more consistent.

Acknowledgements

• I have searched the existing issues and this is a new and no duplicate or related to another open issue.
• I have written a short but informative title.
• I filled out all of the requested information in this issue properly.

[ILoveOpenSourceApplications]

The patch you mentioned serves a different functionality. "Remove player button background" removed the dark circles behind the prev-pause/play-next buttons. The patch you're talking about is "hide player overlay filter".

[tb115]

Yes, my mistake. I have both the hide player overlay filter as well as the remove player background button enabled. Just to reitterate double tapping to skip still darkens entire video.

[ILoveOpenSourceApplications]

Yeah looks like so. I'm pretty sure inotia00 will look into it and fix it eventually.

[s7san007]

@inotia00
Removing dark and foggy overlay filters on tap to seek (FF & RW)
File - res/layout/quick_seek_overlay.xml
Code:

>         android:id="@id/tap_bloom_view"
>         android:focusable="false"
>         android:visibility="gone"
>         android:layout_width="0.0dip"
>         android:layout_height="0.0dip"
>         android:contentDescription="@null"
>         app:endColor="@color/quick_seek_bloom_end"
>         app:startColor="@color/quick_seek_bloom_start" />
>     <ImageView
>         android:id="@id/dark_background"
>         android:visibility="gone"
>         android:layout_width="0.0dip"
>         android:layout_height="0.0dip"
>         android:src="@color/dark_transparent" />

Before:

After:

Please, add a toggle (patch) for removing that filter.

[inotia00]

thank you
but this method seems impossible to control through settings

[tb115]

thank you
but this method seems impossible to control through settings

Can you elaborate on it "being impossible to control". As a long time youtube mobile user it is muscle memory to double tap to skip. If i am watching a video with lots of writing (math tutorial) i dont want to miss out on anything due to the darkening. Edit:typo

[inotia00]

reflected in revanced-patches-v2.168.30

[hi-im-karma]

Wow this is great. Now the overlay filter is even removed when tapping on the screen. Thx to OP for bringing this up and Inotia for implementation 👌🏻

EDIT: @inotia00 Do I need to enable this patch? Just patched to new version and can't find it in settings. Is it enabled by default?

[Spacellary]

Thanks for the quick and continous work, Inotia!

[inotia00]

Wow this is great. Now the overlay filter is even removed when tapping on the screen. Thx to OP for bringing this up and Inotia for implementation 👌🏻

EDIT: @inotia00 Do I need to enable this patch? Just patched to new version and can't find it in settings. Is it enabled by default?

Due to the limitations of the patch method, it cannot be implemented as a setting UI
You have to include in the patching process

[s7san007]

@inotia00, thanks for removing dark filter, but another foggy (light blooming) filter is still visible. :(

Can you remove it in next patches?

[inotia00]

The double tap overlay has two filters

one is a dark overlay
The other is a white circle overlay (image you attached)

Only the patch to remove the dark overlay when double-tapping was implemented, and the patch to remove the white circular overlay was not implemented.

[hi-im-karma]

@inotia00, thanks for removing dark filter, but another foggy (light blooming) filter is still visible. :(

Can you remove it in next patches?

Yes removing "white circle overlay" filter would be great aswell. Please consider this in next release Inotia 👍🏻
(There shouldn't be at any point filters blocking the view..)

[Spacellary]

The other is a white circle overlay (image you attached)

Oh I see, so that's how it works. Hopefully eventually this can be improved but I'm already thankful for this much xD