bug: button containers still visible when turned off

[hlytus]

Type

Cosmetic

Application

youtube 18.10.37 patch 2.166.10

Bug description

Even if the button container setting is off some buttons are still visible.
Sometimes the buttons are just weird.

opening new case because #339 was closed.

Steps to reproduce

1. Go to bottom player layout settings
2. Hide Create, clip and thanks buttons
   doesn't work

Relevant log output

_

Screenshots or videos

Solution

Everything worked fine in patch v2.166.5

Additional context

No response

Device Environment

No response

Acknowledgements

• I have searched the existing issues and this is a new and no duplicate or related to another open issue.
• I have written a short but informative title.
• I filled out all of the requested information in this issue properly.

[inotia00]

Unfortunately, this issue is not fixable

Since the hide-button-container patch has too many bugs,
I will remove the hide-button-container patch in the next release

[hlytus]

Please don't remove it. It works sometimes.
Also while using old YouTube layout, it works without any bugs. It has something to do with new layout.
Suggestion: If you can reorder bottom buttons (or include an option to), we can just reorder create, clip and thanks button to last so even if they appear we won't see them.

[inotia00]

fixed in revanced-patches-v2.166.12

[Vipin2003]

No man...I always use the Share button.
After integrating, I have to enable the useless clip thanks buttons also..😭😭😭 Please revert it back

[hlytus]

Me too. Now i have enabled copy link overlay

[buiducanh142qn]

I think the hide-button-container patch should be removed to avoid affecting the layout.
Even when you turn on the hide action buttons option, the YouTube layout (new layout) looks weird.

[inotia00]

Separating it like before reproduces the bug for some people
(This is also the same for official ReVanced)

The only way to fix the bug completely is to integrate the hide action buttons into one.

[NearCram]

@inotia00 Would it be possible to keep both as seperate patches so people can apply them depending upon which layout they use?

[devilboy1122]

Hide action button are hidden share option not showing

[venkat2305]

Need share option. Please give options to hide the individual buttons.