Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Video ads whitelist not working #652

Closed
3 tasks done
rsaurav12 opened this issue Apr 5, 2023 · 5 comments
Closed
3 tasks done

bug: Video ads whitelist not working #652

rsaurav12 opened this issue Apr 5, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@rsaurav12
Copy link

rsaurav12 commented Apr 5, 2023

Type

Other

Application

YouTube 18.12.35
Patch 2.168.15

Bug description

After Whitelisted any channel for video ads, the ads still won't show up on any video of that channel

Steps to reproduce

  1. include "overlay-button" patch and patch it and then install
  2. go to "overlay button " section in Revanced settings
  3. enable "show whitelist button"
  4. go to your desire channel that you wanna watchlist it
  5. click any video of than channel
  6. tap on Whitelist button on video overlay
  7. tap on ADS
  8. try to watch the same video again or another video of that same channel you watchlisted
  9. you will see ads are still not showing up

Relevant log output

No log

Screenshots or videos

No response

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@rsaurav12 rsaurav12 added the bug Something isn't working label Apr 5, 2023
@inotia00
Copy link
Owner

inotia00 commented Apr 5, 2023

it's weird
Even though I have checked all the code, It can't turn off at all by Hide video ads setting

Once the hide-video-ads patch is included, you can't turn off any way.
(Currently, Google is testing a lot on the server side, so this may be the reason for the bug. At least when I tested it last month, it worked normally)

Would you like to patch with YouTube v18.06.41, the minimum version of RVX and test it?

inotia00 added a commit to inotia00/revanced-integrations that referenced this issue Apr 9, 2023
@rsaurav12
Copy link
Author

rsaurav12 commented Apr 10, 2023

I tested it but still ads won't show up

@inotia00
Copy link
Owner

Only added in commit, not released yet
Perhaps the video ad whitelist feature will be removed

@inotia00
Copy link
Owner

removed in revanced-patches-v2.168.30

@igarca
Copy link

igarca commented Apr 30, 2023

removed in revanced-patches-v2.168.30

I am sad you removed it. It was the reason why I installed RV Extended:( because I could use RV but support useful channels, which I consider very important!
I hope you reconsider it:( Thanks for your work anyways!!

YT-Advanced added a commit to YT-Advanced/testpatches that referenced this issue Sep 6, 2023
vuong2023 pushed a commit to vuong2023/ReX-integrations that referenced this issue Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants