Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: Implement `EventStream` using `mio` #105
This branch changes the implementation of
Since the reactor is intended to drive all IO resources (such as the
This branch shouldn't result in any noticeable changes in behaviour,
Now that #104 is merged, this PR is no longer blocked.
@hawkw I'm a bit clueless about mio/futures/tokio, so I'm not too confident in my ability to provide a good review. That said, I can't find anything wrong with this PR.
There's one thing that's keeping me from merging this right now: There's an open PR (#101) that is a follow-up to the initial futures work (#99). It was blocked back then (may still be?), so I couldn't merge right away. It's my impression that your PR supersedes #101. Is that correct?
@mathstuf This PR seems to supersede your open PR #101. Do you have any thoughts on this PR? I'm considering merging this PR and closing #101. Do you see any reason not to do that? Please note that this is based on a previous PR, and the first 4 commits are already merged. As of this writing, only fa6bf8a and 2c63299 are relevant.
First, just FYI, I've rebased this branch onto master, so the diff should no longer include diffs from PR #104.
Yeah, that's correct. I haven't looked too closely at #101, but here are some of the important differences from my perspective:
referenced this pull request
Jul 4, 2018
added a commit
this pull request
Jul 4, 2018
@olix0r Thank you for the info. If I remember correctly, we decided to land a preliminary version of futures support, as the more efficient version was blocked for various reasons.
Looking back, this seems like a mistake on my part. We should have documented this extensively and hidden it behind a Cargo feature, at the very least. I'm sorry for the trouble this caused for all of you!
@hannobraun I think releasing the futures support experimentally was a good choice on your part, given that otherwise, we wouldn't have found this issue at all.
Honestly, I'm mostly just surprised nobody else hit this issue earlier, as I'm fairly sure could occur any time the
By the way, thanks for being so willing to work with me on landing all the patches I've submitted, I really appreciate it!
Yeah, probably. Judging from the downloads numbers on crates.io, this library must see a fair bit of use. Unfortunately, not a lot gets back to me.
No problem. Thank you for the patches!