Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ChangeLog date instead of build date #97

Merged
merged 2 commits into from Jan 27, 2020

Conversation

bmwiedemann
Copy link
Contributor

Use ChangeLog date instead of build date
in order to make (man-page) builds reproducible.
See https://reproducible-builds.org/ for why this is good.

This date call works with GNU date and BSD date.

This PR was done while working on reproducible builds for openSUSE.

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good.

Also use ISO-8601 date format to be readable worldwide.

This date call works with GNU date and FreeBSD date.
@ericcurtin ericcurtin merged commit 8aa8b20 into inotify-tools:master Jan 27, 2020
@ericcurtin
Copy link
Member

I took this but kept the date format as is like:

date -u -r ChangeLog +'%B %d, %Y'
January 24, 2020

That ok with you @bmwiedemann ?

@bmwiedemann
Copy link
Contributor Author

bmwiedemann commented Jan 27, 2020

I'd still like to know the reasoning for that.
I know, %B is sometimes problematic for reproducible builds, because it varies from locale settings.
It is always good to add a short "because ..." into commit messages.

@ericcurtin
Copy link
Member

Ok no biggie ISO-8601 it is! I'll catch that no need to open a new PR, thanks for your contribution.

@ericcurtin
Copy link
Member

It's here:

4b0245a

@bmwiedemann bmwiedemann deleted the date branch January 28, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants