Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content relations can't be deleted from the "other end" #156

Closed
kraftner opened this issue Aug 27, 2015 · 8 comments

Comments

2 participants
@kraftner
Copy link
Contributor

commented Aug 27, 2015

If you try to remove a content relation from the end it wasn't created originally this doesn't work.

The problem seems to be in Mlp_Content_Relations.php->delete_relation. The where-clause doesn't consider this situation.

I'll continue playing around to see if coming from the wrong side also is an issue with other things like changing a relation.

I also wonder if this is an intended limitation or a known issue.

@kraftner kraftner changed the title content relations aren' Content relations can't be deleted from the "other end" Aug 27, 2015

@tfrommen

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2015

Closed as related to #143.

@tfrommen tfrommen closed this Aug 27, 2015

@kraftner

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2015

I do not understand how that relates to #143.

#143 is about deleting the post. This is about deleting the relation as in "Change Relationship" => "Remove Relationship".

@tfrommen

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2015

Ah, I see. Sorry for that. This will, however, be resolved as soon as the Content Relations refactor is done. Maybe we can provide a temporary fix for this sometime sooner, though.

@tfrommen

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2015

Would you mind checking if the according branch works (for you)?

@kraftner

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2015

Yes this fixes it for me.

Just out of curiosity - what is your reasoning to fix this like this and not inside Mlp_Content_Relations.php->delete_relation?
As the relations aren't directional (even though they are in the DB) I had assumed that should be standard behaviour that is always handled the same. Or is this something you do not want to touch now as it will be covered by the Content Relations refactor?

@tfrommen

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2015

Or is this something you do not want to touch now as it will be covered by the Content Relations refactor?

Yes.

@kraftner

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2015

I see.

@tfrommen tfrommen self-assigned this Aug 28, 2015

@tfrommen

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2015

Closed with 9b54f88.

@tfrommen tfrommen closed this Aug 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.