New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.6 Deprecated wp_get_sites #229

Closed
squibbleFish opened this Issue Aug 22, 2016 · 2 comments

Comments

3 participants
@squibbleFish

squibbleFish commented Aug 22, 2016

Version Information

  • WordPress: 4.6
  • MultilingualPress: 2.4.7

PHP Notice is given due to deprecation of wp_get_sites() in Wordpress 4.6. Should now useget_sites(). Please see ticket here, https://core.trac.wordpress.org/ticket/36994

@bueltge

This comment has been minimized.

Show comment
Hide comment
@bueltge

bueltge Aug 23, 2016

Member

Is implemented in the source - 1856b7e

Member

bueltge commented Aug 23, 2016

Is implemented in the source - 1856b7e

@tfrommen tfrommen added this to the v3.0.0 milestone Aug 23, 2016

@tfrommen

This comment has been minimized.

Show comment
Hide comment
@tfrommen

tfrommen Aug 23, 2016

Contributor

As @bueltge already pointed out, this is already included in the master, but not shipped in the latest patch update (i.e., MultilingualPress 2.4.7). wp_get_sites() does still work, and due to our policy of staying backcompat with two major versions back, the change is (in my opinion) too much for a patch release. The function didn't just get renamed, it also returns completely different things now.

Contributor

tfrommen commented Aug 23, 2016

As @bueltge already pointed out, this is already included in the master, but not shipped in the latest patch update (i.e., MultilingualPress 2.4.7). wp_get_sites() does still work, and due to our policy of staying backcompat with two major versions back, the change is (in my opinion) too much for a patch release. The function didn't just get renamed, it also returns completely different things now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment