New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese Language can't be set #232

Closed
mahmoudkhalafallah opened this Issue Sep 18, 2016 · 4 comments

Comments

2 participants
@mahmoudkhalafallah

mahmoudkhalafallah commented Sep 18, 2016

Version Information

  • WordPress: 4.5
  • MultilingualPress: 2.4.7

Steps to Reproduce

  1. add 2 sites the first is in English, and the Second has to be in Chinese.
  2. while trying to add the Chinese version of your site, click save and wait for page reload.

What I Expected

The site language to be Chinese.

What Happened Instead

The site language is Chinese Singapore instead of Chinese.
as shown in the screenshot the value attribute sent from the select element is the same for both Chinese and Chinese Singapore (zh).

Screenshot or Video

multilingualpress-bug

@tfrommen

This comment has been minimized.

Show comment
Hide comment
@tfrommen

tfrommen Sep 20, 2016

Contributor

Hi there,

I just checked this, and yes, the entry for Chinese (Singapore) is incorrect (and has the same HTTP code as Chinese). We will fix this in a future release.

To get your site running right now, you can edit the language in the Language Manager (to be found at /wp-admin/network/settings.php?page=language-manager). Find Chinese (Singapore), edit the HTTP code to be zh-SG, and save the change.

Best regards,
Thorsten

Contributor

tfrommen commented Sep 20, 2016

Hi there,

I just checked this, and yes, the entry for Chinese (Singapore) is incorrect (and has the same HTTP code as Chinese). We will fix this in a future release.

To get your site running right now, you can edit the language in the Language Manager (to be found at /wp-admin/network/settings.php?page=language-manager). Find Chinese (Singapore), edit the HTTP code to be zh-SG, and save the change.

Best regards,
Thorsten

@tfrommen tfrommen referenced this issue Sep 20, 2016

Closed

Front lang ? #231

@mahmoudkhalafallah

This comment has been minimized.

Show comment
Hide comment
@mahmoudkhalafallah

mahmoudkhalafallah commented Sep 24, 2016

Ok, thank you

@tfrommen

This comment has been minimized.

Show comment
Hide comment
@tfrommen

tfrommen Sep 28, 2016

Contributor

Has been fixed for master in 49d2d92.

Contributor

tfrommen commented Sep 28, 2016

Has been fixed for master in 49d2d92.

@tfrommen tfrommen added this to the v2.4.8 milestone Oct 11, 2016

@tfrommen tfrommen self-assigned this Oct 11, 2016

@tfrommen

This comment has been minimized.

Show comment
Hide comment
@tfrommen

tfrommen Oct 11, 2016

Contributor

Closed with 43f64b1.

Contributor

tfrommen commented Oct 11, 2016

Closed with 43f64b1.

@tfrommen tfrommen closed this Oct 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment