New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database errors after activating #246

Closed
florianbrinkmann opened this Issue Dec 14, 2016 · 6 comments

Comments

3 participants
@florianbrinkmann

Hi!

I activated the current Version 2.4.8 on a 4.7 WordPress multisite install and get the following 3 database errors:

DESCRIBE wp_mlp_languages;
Table 'db.wp_mlp_languages' doesn't exist

DESCRIBE wp_multilingual_linked;
Table 'db.wp_multilingual_linked' doesn't exist

DESCRIBE wp_mlp_site_relations;
Table 'db.wp_mlp_site_relations' doesn't exist

After reloading the page with the installed plugins I get the following errors:

ALTER TABLE wp_mlp_languages ADD KEY `` (`http_name`)
Incorrect index name ''

ALTER TABLE wp_multilingual_linked ADD KEY `` (`ml_blogid`,`ml_elementid`)
Incorrect index name ''

ALTER TABLE wp_mlp_site_relations ADD KEY `` (`site_1`,`site_2`)
Incorrect index name ''
@florianbrinkmann

This comment has been minimized.

Show comment
Hide comment
@florianbrinkmann

florianbrinkmann Dec 14, 2016

Now I tried the code here from GitHub and with that I only get the first set of errors (Table doesn’t exist). After reloading the page, no further errors.

Now I tried the code here from GitHub and with that I only get the first set of errors (Table doesn’t exist). After reloading the page, no further errors.

@tfrommen tfrommen added this to the v2.4.9 milestone Dec 16, 2016

@tfrommen

This comment has been minimized.

Show comment
Hide comment
@tfrommen

tfrommen Dec 16, 2016

Contributor

Hi!

Well, the first set of database errors is not (really) the fault of MultilingualPress, but rather due to dbDelta() being used to alter a table that does not yet exist, see this post, for example, or google for "dbdelta error describe" or so. :)
It's somewhat annoying, yes, but the result is like we want it to be: the tables have been created successfully.
And once the tables are there, dbDelta() won't trigger any errors anymore, so this is only the case when installing MultilingualPress (not on any subsequent re-activations).

The second set of errors has been introduced by the changed KEY (or INDEX) behavior of WordPress 4.6, I believe.
I definitely fixed this for master already (e.g., here), and I thought I also did so in a patch release for the 2.4 branch - which I obviously did not (yet). Sorry.

Expect a release for this by next week. :)

Cheers,
Thorsten

Contributor

tfrommen commented Dec 16, 2016

Hi!

Well, the first set of database errors is not (really) the fault of MultilingualPress, but rather due to dbDelta() being used to alter a table that does not yet exist, see this post, for example, or google for "dbdelta error describe" or so. :)
It's somewhat annoying, yes, but the result is like we want it to be: the tables have been created successfully.
And once the tables are there, dbDelta() won't trigger any errors anymore, so this is only the case when installing MultilingualPress (not on any subsequent re-activations).

The second set of errors has been introduced by the changed KEY (or INDEX) behavior of WordPress 4.6, I believe.
I definitely fixed this for master already (e.g., here), and I thought I also did so in a patch release for the 2.4 branch - which I obviously did not (yet). Sorry.

Expect a release for this by next week. :)

Cheers,
Thorsten

@florianbrinkmann

This comment has been minimized.

Show comment
Hide comment
@florianbrinkmann

florianbrinkmann Dec 17, 2016

Hi Thorsten,

thanks for the explanation!

Expect a release for this by next week. :)

That’s great, thanks for your work :)

Have a nice weekend!
Florian

Hi Thorsten,

thanks for the explanation!

Expect a release for this by next week. :)

That’s great, thanks for your work :)

Have a nice weekend!
Florian

tfrommen added a commit that referenced this issue Dec 19, 2016

@tfrommen

This comment has been minimized.

Show comment
Hide comment
@tfrommen

tfrommen Dec 19, 2016

Contributor

Hi Florian,

can you confirm the latest changes in the 2.4 branch work for you? You can also just grab the ZIP file.

Just let me know and a release will follow within the next days.

Thanks,
Thorsten

Contributor

tfrommen commented Dec 19, 2016

Hi Florian,

can you confirm the latest changes in the 2.4 branch work for you? You can also just grab the ZIP file.

Just let me know and a release will follow within the next days.

Thanks,
Thorsten

@florianbrinkmann

This comment has been minimized.

Show comment
Hide comment
@florianbrinkmann

florianbrinkmann Dec 19, 2016

Hi Thorsten,

looks good, no Incorrect index name errors! :)

Cheers,
Florian

Hi Thorsten,

looks good, no Incorrect index name errors! :)

Cheers,
Florian

@tfrommen tfrommen modified the milestones: v2.5.0, v2.4.9 Dec 23, 2016

@tfrommen

This comment has been minimized.

Show comment
Hide comment
@tfrommen

tfrommen Dec 23, 2016

Contributor

Closed with 391109f.

Contributor

tfrommen commented Dec 23, 2016

Closed with 391109f.

@tfrommen tfrommen closed this Dec 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment