Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMedia Library Grid View JS issue #249
Comments
tfrommen
added
bug
javascript
needs confirmation
labels
Jan 17, 2017
This comment has been minimized.
This comment has been minimized.
Hi @luisarn, thanks for reporting. I had a look at it, and it seems this is an issue with WordPress core. I just created a ticket on Trac. Regarding MultilingualPress: by default, there shouldn't be any MLP JavaScript running on Media. A quick fix would therefore be to find out why I will look into this within the next two weeks or so. Cheers, |
tfrommen
removed
the
needs confirmation
label
Jan 17, 2017
tfrommen
self-assigned this
Jan 31, 2017
added a commit
that referenced
this issue
Feb 1, 2017
added a commit
that referenced
this issue
Feb 1, 2017
tfrommen
added this to the v2.5.1 milestone
Feb 1, 2017
This comment has been minimized.
This comment has been minimized.
Hi @luisarn, while my Trac ticket is waiting to get merged (and eventually released), I fixed the asset loading in MLP. If that is possible, you can try the new branch. Ideal result: the MLP JavaScript is working where it should, and you can use the Media page. :) |
This comment has been minimized.
This comment has been minimized.
Fixed in MultilingualPress v2.5.1. |
luisarn commentedJan 16, 2017
3rd party plugins that relies on Javascript stops working.
Seems the JS loaded again when entering Grid View (check console):
Uncaught Error: Backbone.history has already been started