New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Switcher default Link Text value #262

Closed
Dinamiko opened this Issue Jun 21, 2017 · 2 comments

Comments

2 participants
@Dinamiko
Contributor

Dinamiko commented Jun 21, 2017

Version Information

  • PHP: any
  • WordPress: Latest
  • MLP: 2.6.x

Steps to Reproduce

  1. WordPress Multisite installation with at least 2 connected sites.
  2. At least one Post translated to both languages.
  3. Go to Appearance / Widgets and drag and drop Language Switcher on a Widget area.
  4. Click Visit Site on Admin Bar.

What I Expected

Language Switcher should be shown in the sidebar.

What Happened Instead

Language Switcher doesn't shown in the sidebar.

Why?

01

Because default Link Text value is None.

@Dinamiko

This comment has been minimized.

Show comment
Hide comment
@Dinamiko

Dinamiko Jun 22, 2017

Contributor

I forgot to add #issue-number in the commit, sorry.
535af0e

I tried to cover these 2 cases:

Case 1
As an admin I want to see the Language Switcher in the frontend when I add it to a widget area.

Case 2
As an admin with an already in use Language Switcher configured as:
Link text: None and Show flag: Checked
I want to continue seeing the same after Case 1 is solved.

03

Contributor

Dinamiko commented Jun 22, 2017

I forgot to add #issue-number in the commit, sorry.
535af0e

I tried to cover these 2 cases:

Case 1
As an admin I want to see the Language Switcher in the frontend when I add it to a widget area.

Case 2
As an admin with an already in use Language Switcher configured as:
Link text: None and Show flag: Checked
I want to continue seeing the same after Case 1 is solved.

03

@Dinamiko

This comment has been minimized.

Show comment
Hide comment
@Dinamiko

Dinamiko Jun 23, 2017

Contributor

Fixed in d42be50.

Contributor

Dinamiko commented Jun 23, 2017

Fixed in d42be50.

@Dinamiko Dinamiko closed this Jun 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment