New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links aren't removed when deleting a post #276

Closed
diedexx opened this Issue Aug 4, 2017 · 6 comments

Comments

3 participants
@diedexx
Contributor

diedexx commented Aug 4, 2017

Version Information

  • PHP: any
  • WordPress: any
  • MultilingualPress: 2.7.1

Steps to Reproduce

  1. Create a post
  2. Translate/link the post by creating a new post

edit_product_ _yoast_ _wordpress

  1. Publish the newly linked post
  2. Delete the newly linked post

What I Expected

I expected that the links connecting the two posts to disappear. Or at least that the deleted post wouldn't be linked in the hreflang links

What Happened Instead

The deleted post is still linked referenced, even though the post is no longer accessible.
yoast_seo__the__1_wordpress_seo_plugin_ _yoast

@tfrommen

This comment has been minimized.

Show comment
Hide comment
@tfrommen

tfrommen Aug 4, 2017

Contributor

Relationship data should not be deleted when a post gets trashed (only when it actually gets permanently deleted). But yes, trashed posts should not be included in the hreflang output - as well as potential other things...

Contributor

tfrommen commented Aug 4, 2017

Relationship data should not be deleted when a post gets trashed (only when it actually gets permanently deleted). But yes, trashed posts should not be included in the hreflang output - as well as potential other things...

@tfrommen tfrommen added this to the v2.8.0 milestone Aug 4, 2017

tfrommen added a commit that referenced this issue Aug 4, 2017

tfrommen added a commit that referenced this issue Aug 4, 2017

tfrommen added a commit that referenced this issue Aug 4, 2017

tfrommen added a commit that referenced this issue Aug 4, 2017

@Dinamiko

This comment has been minimized.

Show comment
Hide comment
@Dinamiko

Dinamiko Aug 4, 2017

Contributor

Hi @diedexx,

We have just implement it, can you please test the new branch, 2.8, which should fix both issues.

Thanks,
Emili

Contributor

Dinamiko commented Aug 4, 2017

Hi @diedexx,

We have just implement it, can you please test the new branch, 2.8, which should fix both issues.

Thanks,
Emili

@diedexx

This comment has been minimized.

Show comment
Hide comment
@diedexx

diedexx Aug 7, 2017

Contributor

Hi, Thank's for looking into this so quickly! It looks like it works! However, there's one small issue; the links are shown when there's just a single (available) linked post left. This results in solely a self-reference without any translated alternatives. I don't think it does any harm seo-wise, but it isn't necessary to add hreflang links to a page without translations.
aaaaaaabbbb_-_yoast

Contributor

diedexx commented Aug 7, 2017

Hi, Thank's for looking into this so quickly! It looks like it works! However, there's one small issue; the links are shown when there's just a single (available) linked post left. This results in solely a self-reference without any translated alternatives. I don't think it does any harm seo-wise, but it isn't necessary to add hreflang links to a page without translations.
aaaaaaabbbb_-_yoast

@tfrommen

This comment has been minimized.

Show comment
Hide comment
@tfrommen

tfrommen Aug 8, 2017

Contributor

Hi @diedexx,

yes, I saw that last week already, but wanted to make sure everything is working.
In the 2.8 branch, there is a new filter multilingualpress.render_hreflang that people can use to either force or prevent hreflang rendering.
By default, links will get rendered as soon as there are 2 or more.

I guess this is something you are fine with, right?

Contributor

tfrommen commented Aug 8, 2017

Hi @diedexx,

yes, I saw that last week already, but wanted to make sure everything is working.
In the 2.8 branch, there is a new filter multilingualpress.render_hreflang that people can use to either force or prevent hreflang rendering.
By default, links will get rendered as soon as there are 2 or more.

I guess this is something you are fine with, right?

@diedexx

This comment has been minimized.

Show comment
Hide comment
@diedexx

diedexx Aug 8, 2017

Contributor

Hi @tfrommen, that's perfect, thanks 👍

Contributor

diedexx commented Aug 8, 2017

Hi @tfrommen, that's perfect, thanks 👍

@tfrommen

This comment has been minimized.

Show comment
Hide comment
@tfrommen

tfrommen Aug 8, 2017

Contributor

Cool, then I close this now.

Implemented in 8fa5897.

Contributor

tfrommen commented Aug 8, 2017

Cool, then I close this now.

Implemented in 8fa5897.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment