New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented additional filter to change the output of the list for linked elements #228

Closed
wants to merge 2 commits into
base: master
from

Conversation

4 participants
@lauraquellmalz
Contributor

lauraquellmalz commented Aug 16, 2016

We want to use different markup for our project. So we need a filter to change the output of show_linked_elements(). I've also added the $items and $params to this filter for additional logical stuff.

@tfrommen tfrommen added this to the v3.0.0 milestone Aug 30, 2016

return apply_filters( 'show_linked_elements', $output, $items, $params );
/**
* Filter the output of the linked elementes

This comment has been minimized.

@GaryJones

GaryJones Aug 30, 2016

Typo - extra e, and no full stop.

No @since.

@GaryJones

GaryJones Aug 30, 2016

Typo - extra e, and no full stop.

No @since.

* @param array $items the language items
* @param array $params the parameters which came from the original call
*/
$output = apply_filters( 'mlp_linked_elements_html', $output, $items, $params );

This comment has been minimized.

@GaryJones

GaryJones Aug 30, 2016

No need to assign to a variable first - just return the apply_filters() call.

@GaryJones

GaryJones Aug 30, 2016

No need to assign to a variable first - just return the apply_filters() call.

This comment has been minimized.

@tfrommen
@tfrommen

This comment has been minimized.

@GaryJones

GaryJones Aug 30, 2016

I see - my bad :-)

@GaryJones

GaryJones Aug 30, 2016

I see - my bad :-)

/**
* Filter the output of the linked elementes
*
* @param string $output the generated HTML

This comment has been minimized.

@GaryJones

GaryJones Aug 30, 2016

Redundant spaces after @params.
Descriptions should start with capitals and end with full stops.

@GaryJones

GaryJones Aug 30, 2016

Redundant spaces after @params.
Descriptions should start with capitals and end with full stops.

@tfrommen

This comment has been minimized.

Show comment
Hide comment
@tfrommen

tfrommen Dec 23, 2016

Contributor

Closed with b03cd6f.

Contributor

tfrommen commented Dec 23, 2016

Closed with b03cd6f.

@tfrommen tfrommen closed this Dec 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment