New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to filter possible redirect matches #265

Closed
wants to merge 3 commits into
from

Conversation

2 participants
@diedexx
Contributor

diedexx commented Jul 18, 2017

As discussed with @tfrommen.

What's Included in This Pull Request

  • A new filter to filter the redirect matches.

We want to add geolocation to the redirect formula. This filter will allow us to do so.

@tfrommen

This comment has been minimized.

Show comment
Hide comment
@tfrommen

tfrommen Jul 18, 2017

Contributor

@diedexx I just did some minor changes. Still works for you this way?

Contributor

tfrommen commented Jul 18, 2017

@diedexx I just did some minor changes. Still works for you this way?

@tfrommen tfrommen self-requested a review Jul 18, 2017

@diedexx

This comment has been minimized.

Show comment
Hide comment
@diedexx

diedexx Jul 18, 2017

Contributor

@tfrommen Sure, we can work with that. thnx 👍

Contributor

diedexx commented Jul 18, 2017

@tfrommen Sure, we can work with that. thnx 👍

@tfrommen

This comment has been minimized.

Show comment
Hide comment
@tfrommen

tfrommen Jul 21, 2017

Contributor

Manually merged into new branch, 2.7.

Thanks!

Contributor

tfrommen commented Jul 21, 2017

Manually merged into new branch, 2.7.

Thanks!

@tfrommen tfrommen closed this Jul 21, 2017

@tfrommen

This comment has been minimized.

Show comment
Hide comment
@tfrommen

tfrommen Jul 21, 2017

Contributor

Hey @diedexx, please be aware that I changed the filter to multilingualpress.redirect_targets in order to stay future-proof with the upcoming version 3.

Contributor

tfrommen commented Jul 21, 2017

Hey @diedexx, please be aware that I changed the filter to multilingualpress.redirect_targets in order to stay future-proof with the upcoming version 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment