From cc3e96d707289640a3fb00cd1908e7067e1d813a Mon Sep 17 00:00:00 2001 From: Vanessa Date: Tue, 30 May 2023 20:36:16 +0100 Subject: [PATCH] fix: delete mockKoraLabsHandleProvider --- packages/wallet/src/PersonalWallet/PersonalWallet.ts | 4 ++-- packages/wallet/test/PersonalWallet/load.test.ts | 2 -- packages/wallet/test/PersonalWallet/methods.test.ts | 4 +--- packages/wallet/test/PersonalWallet/rollback.test.ts | 2 -- packages/wallet/test/PersonalWallet/shutdown.test.ts | 2 -- .../wallet/test/integration/CustomObservableWallet.test.ts | 1 - packages/wallet/test/integration/cip30mapping.test.ts | 3 --- packages/wallet/test/integration/util.ts | 4 +--- packages/wallet/test/services/WalletUtil.test.ts | 2 -- 9 files changed, 4 insertions(+), 20 deletions(-) diff --git a/packages/wallet/src/PersonalWallet/PersonalWallet.ts b/packages/wallet/src/PersonalWallet/PersonalWallet.ts index a0384fe3fe3..aa6b6cf734d 100644 --- a/packages/wallet/src/PersonalWallet/PersonalWallet.ts +++ b/packages/wallet/src/PersonalWallet/PersonalWallet.ts @@ -108,7 +108,7 @@ export interface PersonalWalletDependencies { readonly txSubmitProvider: TxSubmitProvider; readonly stakePoolProvider: StakePoolProvider; readonly assetProvider: AssetProvider; - readonly handleProvider: HandleProvider; + readonly handleProvider?: HandleProvider; readonly networkInfoProvider: WalletNetworkInfoProvider; readonly utxoProvider: UtxoProvider; readonly chainHistoryProvider: ChainHistoryProvider; @@ -198,7 +198,7 @@ export class PersonalWallet implements ObservableWallet { readonly name: string; readonly util: WalletUtil; readonly rewardsProvider: TrackedRewardsProvider; - readonly handleProvider: HandleProvider; + readonly handleProvider?: HandleProvider; // eslint-disable-next-line max-statements constructor( diff --git a/packages/wallet/test/PersonalWallet/load.test.ts b/packages/wallet/test/PersonalWallet/load.test.ts index a981578f12d..9c3d52942cd 100644 --- a/packages/wallet/test/PersonalWallet/load.test.ts +++ b/packages/wallet/test/PersonalWallet/load.test.ts @@ -108,7 +108,6 @@ const createWallet = async (props: CreateWalletProps) => { const txSubmitProvider = mocks.mockTxSubmitProvider(); const assetProvider = mocks.mockAssetProvider(); const stakePoolProvider = createStubStakePoolProvider(); - const handleProvider = mocks.mockKoraLabsHandleProvider(); return new PersonalWallet( { name, polling: props.pollingConfig }, @@ -117,7 +116,6 @@ const createWallet = async (props: CreateWalletProps) => { assetProvider, chainHistoryProvider, connectionStatusTracker$, - handleProvider, keyAgent, logger, networkInfoProvider, diff --git a/packages/wallet/test/PersonalWallet/methods.test.ts b/packages/wallet/test/PersonalWallet/methods.test.ts index 9cda2f6501f..370eb8bbd30 100644 --- a/packages/wallet/test/PersonalWallet/methods.test.ts +++ b/packages/wallet/test/PersonalWallet/methods.test.ts @@ -11,7 +11,7 @@ import { getPassphrase, stakeKeyDerivationPath, testAsyncKeyAgent } from '../../ import { dummyLogger as logger } from 'ts-log'; import { toOutgoingTx, waitForWalletStateSettle } from '../util'; -const { mockChainHistoryProvider, mockRewardsProvider, utxo, mockKoraLabsHandleProvider } = mocks; +const { mockChainHistoryProvider, mockRewardsProvider, utxo } = mocks; // We can't consistently re-serialize this specific tx due to witness.datums list format const serializedForeignTx = @@ -61,7 +61,6 @@ describe('PersonalWallet methods', () => { const stakePoolProvider = createStubStakePoolProvider(); const rewardsProvider = mockRewardsProvider(); const chainHistoryProvider = mockChainHistoryProvider(); - const handleProvider = mockKoraLabsHandleProvider(); const groupedAddress: GroupedAddress = { accountIndex: 0, address, @@ -84,7 +83,6 @@ describe('PersonalWallet methods', () => { { assetProvider, chainHistoryProvider, - handleProvider, keyAgent, logger, networkInfoProvider, diff --git a/packages/wallet/test/PersonalWallet/rollback.test.ts b/packages/wallet/test/PersonalWallet/rollback.test.ts index 0be2d4e6cd3..11b287ec079 100644 --- a/packages/wallet/test/PersonalWallet/rollback.test.ts +++ b/packages/wallet/test/PersonalWallet/rollback.test.ts @@ -58,7 +58,6 @@ const createWallet = async (stores: WalletStores, providers: Providers, pollingC } = providers; const assetProvider = mocks.mockAssetProvider(); const stakePoolProvider = createStubStakePoolProvider(); - const handleProvider = mocks.mockKoraLabsHandleProvider(); return new PersonalWallet( { name, polling: pollingConfig }, @@ -66,7 +65,6 @@ const createWallet = async (stores: WalletStores, providers: Providers, pollingC assetProvider, chainHistoryProvider, connectionStatusTracker$, - handleProvider, keyAgent, logger, networkInfoProvider, diff --git a/packages/wallet/test/PersonalWallet/shutdown.test.ts b/packages/wallet/test/PersonalWallet/shutdown.test.ts index 997542c2d74..50abd0f17f7 100644 --- a/packages/wallet/test/PersonalWallet/shutdown.test.ts +++ b/packages/wallet/test/PersonalWallet/shutdown.test.ts @@ -76,7 +76,6 @@ const createWallet = async ( const txSubmitProvider = mocks.mockTxSubmitProvider(); const assetProvider = mocks.mockAssetProvider(); const stakePoolProvider = createStubStakePoolProvider(); - const handleProvider = mocks.mockKoraLabsHandleProvider(); return new PersonalWallet( { name, polling: pollingConfig }, @@ -84,7 +83,6 @@ const createWallet = async ( assetProvider, chainHistoryProvider, connectionStatusTracker$, - handleProvider, keyAgent, logger, networkInfoProvider, diff --git a/packages/wallet/test/integration/CustomObservableWallet.test.ts b/packages/wallet/test/integration/CustomObservableWallet.test.ts index fe4fff051e7..31bcaf61cb1 100644 --- a/packages/wallet/test/integration/CustomObservableWallet.test.ts +++ b/packages/wallet/test/integration/CustomObservableWallet.test.ts @@ -47,7 +47,6 @@ describe('CustomObservableWallet', () => { { assetProvider: mocks.mockAssetProvider(), chainHistoryProvider: mocks.mockChainHistoryProvider(), - handleProvider: mocks.mockKoraLabsHandleProvider(), keyAgent: await testAsyncKeyAgent(), logger, networkInfoProvider: mocks.mockNetworkInfoProvider(), diff --git a/packages/wallet/test/integration/cip30mapping.test.ts b/packages/wallet/test/integration/cip30mapping.test.ts index 4eb1d1b26ae..d2de16662dc 100644 --- a/packages/wallet/test/integration/cip30mapping.test.ts +++ b/packages/wallet/test/integration/cip30mapping.test.ts @@ -35,7 +35,6 @@ import { waitForWalletStateSettle } from '../util'; const { mockChainHistoryProvider, - mockKoraLabsHandleProvider, mockNetworkInfoProvider, mockRewardsProvider, mockTxSubmitProvider, @@ -529,7 +528,6 @@ describe('cip30', () => { const stakePoolProvider = createStubStakePoolProvider(); const rewardsProvider = mockRewardsProvider(); const chainHistoryProvider = mockChainHistoryProvider(); - const handleProvider = mockKoraLabsHandleProvider(); const groupedAddress: GroupedAddress = { accountIndex: 0, address, @@ -552,7 +550,6 @@ describe('cip30', () => { { assetProvider, chainHistoryProvider, - handleProvider, keyAgent, logger, networkInfoProvider, diff --git a/packages/wallet/test/integration/util.ts b/packages/wallet/test/integration/util.ts index a1e5cceb66d..29a4c51a695 100644 --- a/packages/wallet/test/integration/util.ts +++ b/packages/wallet/test/integration/util.ts @@ -12,14 +12,12 @@ const { mockNetworkInfoProvider, mockRewardsProvider, mockTxSubmitProvider, - mockUtxoProvider, - mockKoraLabsHandleProvider + mockUtxoProvider } = mockProviders; const createDefaultProviders = () => ({ assetProvider: mockAssetProvider(), chainHistoryProvider: mockChainHistoryProvider(), - handleProvider: mockKoraLabsHandleProvider(), networkInfoProvider: mockNetworkInfoProvider(), rewardsProvider: mockRewardsProvider(), stakePoolProvider: createStubStakePoolProvider(), diff --git a/packages/wallet/test/services/WalletUtil.test.ts b/packages/wallet/test/services/WalletUtil.test.ts index c9449e7bf4f..82e544689a0 100644 --- a/packages/wallet/test/services/WalletUtil.test.ts +++ b/packages/wallet/test/services/WalletUtil.test.ts @@ -84,7 +84,6 @@ describe('WalletUtil', () => { const stakePoolProvider = createStubStakePoolProvider(); const rewardsProvider = mocks.mockRewardsProvider(); const chainHistoryProvider = mocks.mockChainHistoryProvider(); - const handleProvider = mocks.mockKoraLabsHandleProvider(); const groupedAddress: GroupedAddress = { accountIndex: 0, address, @@ -107,7 +106,6 @@ describe('WalletUtil', () => { { assetProvider, chainHistoryProvider, - handleProvider, keyAgent, logger, networkInfoProvider,