Change the CLI's MIR cert command to take stake addresses #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoutts
requested review from
erikd,
intricate,
Jimbo4350,
mrBliss and
newhoggy
as code owners
disassembler
approved these changes
Jan 17, 2021
Jimbo4350
approved these changes
Jan 18, 2021
Jimbo4350
force-pushed
the
dcoutts/cli-mir-stake-address
branch
from
491540a
to
67e0a8a
Compare
Instead of taking stake verification key files. Stake addresses is the more sensible choice since MIR certs really contain a stake credential and a stake address is basically a wrapper for a stake credential. There's no need to keep both options (key files and stake addrs) since we can already convert from a stake vkey file to a stake address. It's strictly more general, since this now support script-flavour stake addresses. And sometimes we only have the stake address, not the vkey.
Jimbo4350
force-pushed
the
dcoutts/cli-mir-stake-address
branch
from
67e0a8a
to
9b6e8e8
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of taking stake verification key files. Stake addresses is the
more sensible choice since MIR certs really contain a stake credential
and a stake address is basically a wrapper for a stake credential.
There's no need to keep both options (key files and stake addrs) since
we can already convert from a stake vkey file to a stake address.
It's strictly more general, since this now support script-flavour stake
addresses. And sometimes we only have the stake address, not the vkey.