Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Resurrect broken benchmark programs #3005

Merged
merged 3 commits into from
May 29, 2018
Merged

Resurrect broken benchmark programs #3005

merged 3 commits into from
May 29, 2018

Conversation

erikd
Copy link
Member

@erikd erikd commented May 29, 2018

Description

I thought benchmark programs were being built in CI but obviously they are not or these issues would have been found before they were merged to develop.

This may actually be due to a bug in stack.

Linked issue

N/A

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Ran:

stack test && stack bench --no-run-benchmarks

erikd added 2 commits May 29, 2018 13:24
This has bit rotted because benchmarks are not being build in CI.
Copy link
Contributor

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks are still not built by the CI right?
Do we have a ticket tracking this?

@erikd
Copy link
Member Author

erikd commented May 29, 2018

Yes, there is a devops ticket tracking this.

@erikd erikd merged commit 5c4f20c into develop May 29, 2018
@erikd erikd deleted the erikd/fix-benchmarks branch July 26, 2018 10:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants