cardano-node: 1.19.1-patched -> 1.20.0 #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
added
the
IMPROVEMENT
rvl
changed the title
rvl
force-pushed
the
rvl/2098/json-metadata
branch
from
e09eef7
to
113ee6f
Compare
rvl
force-pushed
the
rvl/2098/json-metadata
branch
from
223114d
to
323fb02
Compare
|
bors try |
tryBuild failed: |
rvl
force-pushed
the
rvl/2098/json-metadata
branch
from
e571aaf
to
8b9932e
Compare
Anviking
approved these changes
Sep 17, 2020
KtorZ
reviewed
Sep 17, 2020
| @@ -1398,18 +1398,59 @@ components: | |||
| passphrase: *lenientPassphrase | |||
| address_index: *addressIndex | |||
|
|
|||
| TransactionMetadatum: &TransactionMetadatum | |||
| TransactionMetadataValue: &TransactionMetadataValue | |||
There was a problem hiding this comment.
We need to confirm this with @AlexIOHK . In theory, 1.20.0 supports both approaches for metadata, the one we currently use with direct JSON conversion, and this one that is more of a JSON description of the metadata.
I'd have preferred going for the JSON description initially, but we had to get partners started with something and went for the direct JSON conversion which was ready. If we change that, it'll break existing integrations (although that is rather trivially fixed).
There was a problem hiding this comment.
OK I have changed the API to use the "no schema" mapping from cardano-api. I think it's the same as before. The PR for changing to the detailed schema is #2147.
rvl
force-pushed
the
rvl/2098/json-metadata
branch
from
8b9932e
to
2d41f15
Compare
rvl
force-pushed
the
rvl/2098/json-metadata
branch
from
e5ad680
to
b335bae
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 21, 2020
2142: cardano-node: 1.19.1-patched -> 1.20.0 r=rvl a=rvl ### Issue Number ADP-307 / #2098 ### Overview Updates cardano-node to [1.20.0](https://github.com/input-output-hk/cardano-node/releases/tag/1.20.0) There are quite a few upstream API changes. Snapshot PR is input-output-hk/cardano-haskell#28. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
|
bors r- |
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 21, 2020
2147: Use JSON "detailed schema" for API TxMetadata r=KtorZ a=rvl ### Issue Number ADP-307 / #2073 ### Overview Changes the API to use the "detailed" JSON schema for transaction metadata. With this scheme, API users will always see exactly the same JSON in the transaction history and cardano explorer as what they submitted with the transaction. ### Comments We may wish to support both formats in the API. This PR is based on the branch of #2142. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-307 / #2098
Overview
Updates cardano-node to 1.20.0
There are quite a few upstream API changes.
Snapshot PR is input-output-hk/cardano-haskell#28.