fix(catalyst-toolbox): Fix error when purpose is null. | NPG-0000 #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chain address with the snapshot.
stevenj
changed the title
minikin
previously requested changes
Aug 25, 2023
stevenj
dismissed
minikin’s stale review
Test are fragile, so while the suggested change is probably correct, the implementation tries to keep the original code as close as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catalyst toolbox was crashing if "purpose" was Null in a registration.
This fixes that, so Null is properly detected as a "Catalyst" registration.
Also, it adds the pre-calculated Jormungandr chain address, because its non trivial to go from the voting key to the chain address used by Jormungandr.
This lets me compare the SVE snapshot with the normal snapshot, and it shows the SVE snapshot has rounding errors which will negatively effect people with multiple registrations on the same key.
Recommendation is for Audit, we publish the updated
snapshotartifact, not the one we import into vit-ss. And then make a quick program to convert thesnapshotartifact into a format needed for vit-ss for F10. Theutilities/snapshot-check/compare_snapshot.pywould need a couple of tweaks to be such a tool.