Skip to content

Conversation

@apskhem
Copy link
Collaborator

@apskhem apskhem commented Nov 27, 2025

Description

  • Added ArrayDeterministic variant into DecodeCtx, when decoding an array with the context, it decodes and sorts accordingly to Section 4.2.3

Related Issue(s)

#656

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem self-assigned this Nov 27, 2025
@apskhem apskhem added the squad: gatekeepers Catalyst App Backend, System Development & Integration Team label Nov 27, 2025
@apskhem apskhem added this to Catalyst Nov 27, 2025
@apskhem apskhem added the draft Draft label Nov 27, 2025
@apskhem apskhem moved this from New to 🏗 In progress in Catalyst Nov 27, 2025
@apskhem apskhem marked this pull request as draft November 27, 2025 13:10
@apskhem apskhem added review me PR is ready for review and removed draft Draft labels Nov 27, 2025
@apskhem apskhem moved this from 🏗 In progress to 👀 In review in Catalyst Nov 27, 2025
@apskhem apskhem marked this pull request as ready for review November 27, 2025 13:37
@github-actions
Copy link
Contributor

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/libs/feat/deterministic-array-cbor

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

Test Report | ${\color{lightgreen}Pass: 583/583}$ | ${\color{red}Fail: 0/583}$ |

@github-project-automation github-project-automation bot moved this from 👀 In review to 🔖 Ready in Catalyst Nov 27, 2025
@apskhem apskhem requested a review from Mr-Leshiy November 27, 2025 15:43
@apskhem apskhem moved this from 🔖 Ready to 👀 In review in Catalyst Nov 27, 2025
Mr-Leshiy
Mr-Leshiy previously approved these changes Nov 28, 2025
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apskhem apskhem merged commit 546cbad into main Nov 28, 2025
23 checks passed
@apskhem apskhem deleted the feat/deterministic-array-cbor branch November 28, 2025 09:18
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

CBOR deterministic decoding for Array entries for Collaborators and DocumentRefs types.

3 participants