Fix envInfo evm test #747
Merged
Fix envInfo evm test #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yevhenii Babichenko <eugene.babichenko@iohk.io>
Co-authored-by: Yevhenii Babichenko <eugene.babichenko@iohk.io>
Co-authored-by: Yevhenii Babichenko <eugene.babichenko@iohk.io>
Co-authored-by: Yevhenii Babichenko <eugene.babichenko@iohk.io>
Mr-Leshiy
requested review from
eugene-babichenko and
saibatizoku
and removed request for
eugene-babichenko
saibatizoku
reviewed
Mar 7, 2022
| /// EVM Block Configuration. | ||
| config: Config, | ||
| environment: &'runtime Environment, | ||
| environment: &'runtime mut Environment, |
Contributor
There was a problem hiding this comment.
I'm not sure that the VM should mutate the environment outside of tests.
saibatizoku
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly need to merge #743