Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-430] Flow and linting setup improvements #1124

Merged
merged 17 commits into from Oct 26, 2018

Conversation

DominikGuzei
Copy link
Member

This PR fixes our broken flow setup (forever, and ever and ever ever?) by introducing eslint-plugin-flowtype which lints the flow specific mistakes like forgetting to add // @flow and thus breaking the whole idea of using a type checker.

Of course it also fixes the ~hundred of errors that popped up once the setup was fixed 馃檮
Also updates to latest flow-bin version.


Review Checklist:

Basics

  • PR is updated to the most recent version of target branch (and there are no conflicts)
  • PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub
  • Automated tests: All acceptance tests are passing (yarn run test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn run dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn run package / CI builds)
  • There are no flow errors or warnings (yarn run flow:test)
  • There are no lint errors or warnings (yarn run lint)
  • Text changes are proofread and approved (Jane Wild)
  • There are no missing translations (running yarn run manage:translations produces no changes)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn run storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly documented and commented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-rendering
  • Any code that only works in Electron is neatly separated from components

Testing

  • New feature / change is covered by acceptance tests
  • All existing acceptance tests are still up-to-date
  • New feature / change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review:

  • Merge PR
  • Delete source branch
  • Move ticket to done on the Youtrack board

@nikolaglumac nikolaglumac changed the title Fix/ddw 430 flow and linting setup [DDW-430] Flow and linting setup improvements Oct 15, 2018
@DominikGuzei
Copy link
Member Author

@nikolaglumac i updated this PR to latest develop and moved the changelog entry to vNext

@DominikGuzei
Copy link
Member Author

@nikolaglumac please review this as we should get this setup into develop asap.

@DominikGuzei
Copy link
Member Author

@cleverca22 @disassembler can you take a look at the failing hydra tests? it seems to be some CI issue

@nikolaglumac
Copy link
Contributor

@DominikGuzei we have a failing buildkite build here - we need to figure it out before we can merge this PR 馃檹
cc @cleverca22 @disassembler

@DominikGuzei
Copy link
Member Author

@nikolaglumac it seems to be the same issue as with hydra tests:

stat: No such file or directory
--
聽 | error: build of '/nix/store/36529l5nkzmy9q8kjfpkr1zq2gkz0chx-daedalus-modules-0.12.0.drv' failed

nikolaglumac
nikolaglumac previously approved these changes Oct 26, 2018
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @DominikGuzei - It is a true relief to see that we are now officially doing all the flow-typing and linting "by-the-book" :) 馃帀

Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @DominikGuzei & @deepfire 馃帀

@nikolaglumac nikolaglumac merged commit e93e455 into develop Oct 26, 2018
@nikolaglumac nikolaglumac deleted the fix/ddw-430-flow-and-linting-setup branch October 26, 2018 17:21
@nikolaglumac nikolaglumac mentioned this pull request Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants