New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-430] Flow and linting setup improvements #1124
Conversation
@nikolaglumac i updated this PR to latest |
@nikolaglumac please review this as we should get this setup into |
@cleverca22 @disassembler can you take a look at the failing hydra tests? it seems to be some CI issue |
@DominikGuzei we have a failing buildkite build here - we need to figure it out before we can merge this PR 馃檹 |
@nikolaglumac it seems to be the same issue as with hydra tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @DominikGuzei - It is a true relief to see that we are now officially doing all the flow-typing and linting "by-the-book" :) 馃帀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @DominikGuzei & @deepfire 馃帀
This PR fixes our broken flow setup (forever, and ever and ever ever?) by introducing
eslint-plugin-flowtype
which lints the flow specific mistakes like forgetting to add// @flow
and thus breaking the whole idea of using a type checker.Of course it also fixes the ~hundred of errors that popped up once the setup was fixed 馃檮
Also updates to latest flow-bin version.
Review Checklist:
Basics
yarn run test
)yarn run dev
)yarn run package
/ CI builds)yarn run flow:test
)yarn run lint
)yarn run manage:translations
produces no changes)yarn run storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review:
done
on the Youtrack board