Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.13.0 #1315

Merged
merged 1,118 commits into from Mar 20, 2019

Conversation

Projects
None yet
8 participants
@nikolaglumac
Copy link
Contributor

commented Feb 22, 2019

0.13.0

Features

  • New validation message for transactions which are to big in data size (PR 1308, PR 1331)
  • Structured logging for Daedalus in JSON format, matching the structured logging format used in Cardano SL (PR 1299)
  • Additional instructions for paper wallet certificate creation (PR 1309)
  • Performant rendering of big lists using virtual lists, applied to lists of transactions and addresses (PR 1276, PR 1303, PR 1305, PR 1306, PR 1312, PR 1313)
  • "System-info.json" file saved in the public log folder, containing the system specification of the user's computer running Daedalus (PR 1292)
  • Block storage consolidation status screen, available from the application menu (PR 1275, PR 1294)
  • Application menu in English and Japanese (PR 1262, PR 1296)
  • Notification for log download completion (PR 1228)
  • Handling low disk space operation, including warning message and stopping Cardano node to prevent data corruption (PR 1157)
  • Improved clock synchronisation checks (NTP) (PR 1258, PR 1319)
  • Support for "frontend-only" mode (PR 1241, PR 1260)
  • Improved user experience for multiple running Daedalus instances by replacing "Daedalus is already running" dialog with focusing of the already running Daedalus instance (PR 1229)
  • Replaced in-app support request with links to support page (PR 1199, PR 1331)
  • Improved user experience for inline editing fields (like wallet renaming) (PR 1231)
  • Added a BESTPRACTICES.md document containing rules and recommendations for writing better JavaScript and CSS (PR 1233)
  • Refactoring to disable Node JS integration in Electron's rendering processes (PR 1099)
  • Daedalus Windows installer/uninstaller multi-language support and English and Japanese translations (PR 1287, PR 1298, PR 1322)

Fixes

  • Fixed Dev-Tools initialization in development mode (PR 1302)
  • Fixed text selection issues (disabled drag and drop of selected text and enabled unselect option) (PR 1289)
  • Disabled the default behavior of the context menu following a right click for non-input elements (PR 1281)
  • Initial setup of language locale and terms of use available before Cardano node is connected to network (PR 1279, PR 1284)
  • Fixed ps-list issues which caused false detection of already running Daedalus instance (PR 1266)
  • Fixed getTransactionHistory API endpoint account index query parameter name (PR 1255)
  • Fixed issues with custom lock files by implementing "instance-lock" feature from Electron 3 (PR 1229, PR 1244)
  • Fixed application reloading issues in the Ada Redemption page (PR 1217)
  • Fixed the contents of /etc/nix/nix.conf file listed as a part of Cardano setup in Daedalus README file (PR 1215)
  • Fixed the partly broken Flow setup (PR 1124)
  • Fixed failing apply-node-update test (PR 1156)
  • Removed antivirus notification which was presented during wallet restoration (PR 1164)
  • Fixed design implementations issues (PR 1209)
  • Fixed the flickering issue on "Network Status" screen syncing chart (PR 1206)

Chores

  • Added support for newly introduced UtxoNotEnoughFragmented API error message (PR 1297)
  • Changed the behavior of "Network status" from screen to dialog (PR 1286)
  • Updated the list of contributors on the "About" screen (PR 1282)
  • Added more logging for API errors (PR 1278
  • Removed node version check as nix shell is enforcing the version (PR 1236)
  • Fixed Daedalus shell to evaluate embedded variables properly (PR 1235)
  • Added --rp prefixed CSS variables to Daedalus themes to configure styles of React-Polymorph components and removed SimpleTheme imports previously used for React-Polymorph overrides in favor of using ThemeProvider's themeOverrides feature (PR 1139)
  • Changed API call logging level from debug to info (PR 1183)
  • Enabled Cardano Wallet API documentation server in development mode - reacheable on https://localhost:8091/docs/v1/index/ (PR 1187)
  • Updated application dependencies (PR 1201, PR 1216, PR 1227, PR 1251, PR 1265)

MarcusHurney and others added some commits Jan 31, 2019

Merge pull request #1297 from input-output-hk/chore/ddw-573-update-tr…
…ansactions-api-error-handling

[DDW-573] Update transactions API error handling
Merge branch 'feature/ddw-565-improve-performance-of-rendering-huge-l…
…ists' of https://github.com/input-output-hk/daedalus into feature/ddw-565-improve-performance-of-rendering-huge-lists
Merge branch 'develop' of github.com:input-output-hk/daedalus into fe…
…ature/ddw-517-implement-structured-logging-for-daedalus-logs

[DDW-517] Merges latest develop branch
Merge branch 'feature/ddw-565-improve-performance-of-rendering-huge-l…
…ists' of github.com:input-output-hk/daedalus into feature/ddw-565-improve-performance-of-rendering-huge-lists

cleverca22 and others added some commits Feb 27, 2019

[DDW-465] fix uninstaller unicode
(cherry picked from commit cae85ad)
[DEVOPS-1238] update the windows signing certificate and secret
the CERT_PASS has been encrypted and only appveyor can decrypt it:
https://www.appveyor.com/docs/build-configuration/#secure-variables

(cherry picked from commit 24921f9)
Merge pull request #1324 from input-output-hk/bump-release-cert
[DEVOPS-1238] Update the Windows signing certificate and secret
Merge #1322
1322: [DEVOPS-1237] Character encoding issues in Windows uninstaller r=nikolaglumac a=cleverca22

(cherry picked from commit a3baf33)

This PR fixes the uninstaller translations.

---

## Review Checklist:

### Basics

- [ ] PR is updated to the most recent version of target branch (and there are no conflicts)
- [ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
- [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub
- [ ] Automated tests: All acceptance tests are passing (`yarn run test`)
- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn run dev`)
- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn run package` / CI builds)
- [ ] There are no *flow* errors or warnings (`yarn run flow:test`)
- [ ] There are no *lint* errors or warnings (`yarn run lint`)
- [ ] Text changes are proofread and approved (Jane Wild)
- [ ] There are no missing translations (running `yarn run manage:translations` produces no changes)
- [ ] UI changes look good in all themes (Alexander Rukin)
- [ ] Storybook works and no stories are broken (`yarn run storybook`)
- [ ] In case of dependency changes `yarn.lock` file is updated

### Code Quality
- [ ] Important parts of the code are properly documented and commented
- [ ] Code is properly typed with flow
- [ ] React components are split-up enough to avoid unnecessary re-rendering
- [ ] Any code that only works in Electron is neatly separated from components

### Testing
- [ ] New feature / change is covered by acceptance tests
- [ ] All existing acceptance tests are still up-to-date
- [ ] New feature / change is covered by Daedalus Testing scenario
- [ ] All existing Daedalus Testing scenarios are still up-to-date

### After Review:
- [ ] Merge PR
- [ ] Delete source branch
- [ ] Move ticket to `done` on the Youtrack board


Co-authored-by: Michael Bishop <michael.bishop@iohk.io>
Co-authored-by: Nikola Glumac <niglumac@gmail.com>
[DDW-465] fix uninstaller unicode
(cherry picked from commit fb8013a)
Merge #1326
1326: [DEVOPS-1237] Fix uninstaller unicode r=nikolaglumac a=cleverca22

This PR CHANGES.
#1321 (the PR that was closed) was the one with the fix
#1322 (the PR that was merged in favor of it), was not yet updated, and lacked the fix

this new PR applies the fix to release branch
## Todo:

- [ ] Todo
- [ ] Todo
- [ ] Todo

## Screenshots:

- Screenshot

---

## Review Checklist:

### Basics

- [ ] PR is updated to the most recent version of target branch (and there are no conflicts)
- [ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
- [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub
- [ ] Automated tests: All acceptance tests are passing (`yarn run test`)
- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn run dev`)
- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn run package` / CI builds)
- [ ] There are no *flow* errors or warnings (`yarn run flow:test`)
- [ ] There are no *lint* errors or warnings (`yarn run lint`)
- [ ] Text changes are proofread and approved (Jane Wild)
- [ ] There are no missing translations (running `yarn run manage:translations` produces no changes)
- [ ] UI changes look good in all themes (Alexander Rukin)
- [ ] Storybook works and no stories are broken (`yarn run storybook`)
- [ ] In case of dependency changes `yarn.lock` file is updated

### Code Quality
- [ ] Important parts of the code are properly documented and commented
- [ ] Code is properly typed with flow
- [ ] React components are split-up enough to avoid unnecessary re-rendering
- [ ] Any code that only works in Electron is neatly separated from components

### Testing
- [ ] New feature / change is covered by acceptance tests
- [ ] All existing acceptance tests are still up-to-date
- [ ] New feature / change is covered by Daedalus Testing scenario
- [ ] All existing Daedalus Testing scenarios are still up-to-date

### After Review:
- [ ] Merge PR
- [ ] Delete source branch
- [ ] Move ticket to `done` on the Youtrack board


Co-authored-by: Michael Bishop <michael.bishop@iohk.io>
Merge pull request #1328 from input-output-hk/revert-cert-change
Revert "[DEVOPS-1238] update the windows signing certificate and secret"
Merge pull request #1329 from input-output-hk/csl-bump
Bump Cardano revision to the tip of the release/3.0.0 branch
darko-mijic
Merge pull request #1331 from input-output-hk/chore/ddw-587-improve-s…
…upport-page-text

[DDW-587] Improve support page text
Merge pull request #1340 from input-output-hk/fix/ddw-592-make-sure-w…
…allets-data-is-reloaded-after-node-restart

[DDW-592] Make sure wallets data is reloaded after Daedalus reconnects
Merge #1342
1342: bump cardano rev to tip of cardano-sl develop r=disassembler a=cleverca22

This PR CHANGES.

## Todo:

- [ ] Todo
- [ ] Todo
- [ ] Todo

## Screenshots:

- Screenshot

---

## Review Checklist:

### Basics

- [ ] PR is updated to the most recent version of target branch (and there are no conflicts)
- [ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
- [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub
- [ ] Automated tests: All acceptance tests are passing (`yarn run test`)
- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn run dev`)
- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn run package` / CI builds)
- [ ] There are no *flow* errors or warnings (`yarn run flow:test`)
- [ ] There are no *lint* errors or warnings (`yarn run lint`)
- [ ] Text changes are proofread and approved (Jane Wild)
- [ ] There are no missing translations (running `yarn run manage:translations` produces no changes)
- [ ] UI changes look good in all themes (Alexander Rukin)
- [ ] Storybook works and no stories are broken (`yarn run storybook`)
- [ ] In case of dependency changes `yarn.lock` file is updated

### Code Quality
- [ ] Important parts of the code are properly documented and commented
- [ ] Code is properly typed with flow
- [ ] React components are split-up enough to avoid unnecessary re-rendering
- [ ] Any code that only works in Electron is neatly separated from components

### Testing
- [ ] New feature / change is covered by acceptance tests
- [ ] All existing acceptance tests are still up-to-date
- [ ] New feature / change is covered by Daedalus Testing scenario
- [ ] All existing Daedalus Testing scenarios are still up-to-date

### After Review:
- [ ] Merge PR
- [ ] Delete source branch
- [ ] Move ticket to `done` on the Youtrack board


Co-authored-by: Michael Bishop <michael.bishop@iohk.io>
Merge pull request #1346 from input-output-hk/release-unicode-fix
[RCD-56] Fix Windows unicode problem

@nikolaglumac nikolaglumac merged commit 4868ada into master Mar 20, 2019

6 checks passed

buildkite/daedalus Build #4954 passed (9 minutes, 53 seconds)
Details
ci/hydra:serokell:daedalus:tests.runFlow Hydra build #691784 of serokell:daedalus-pr-1315:tests.runFlow
Details
ci/hydra:serokell:daedalus:tests.runLint Hydra build #691786 of serokell:daedalus-pr-1315:tests.runLint
Details
ci/hydra:serokell:daedalus:tests.runShellcheck Hydra build #691780 of serokell:daedalus-pr-1315:tests.runShellcheck
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.