-
Notifications
You must be signed in to change notification settings - Fork 298
[DDW-827] Show helpful message when trying to empty wallet containing native tokens #2783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
danielmain
merged 57 commits into
develop
from
feature/ddw-827-empty-wallet-with-tokens
Feb 23, 2022
Merged
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
4ad3c05
[DDW-827] show helpful message
3e5e5c5
Merge branch 'develop' into feature/ddw-827-empty-wallet-with-tokens
mchappell 469988a
Merge branch 'develop' into feature/ddw-827-empty-wallet-with-tokens
mchappell 160e7c0
[DDW-827] updated error message and translations
mchappell 56af6df
[DDW-827] fixed flow types for sendMoney
mchappell 2b253a3
[DDW-827] updated CHANGELOG
mchappell 825a6fe
Merge branch 'develop' into feature/ddw-827-empty-wallet-with-tokens
mchappell 9815f89
Merge branch 'develop' into feature/ddw-827-empty-wallet-with-tokens
mchappell fae171e
Merge branch 'develop' into feature/ddw-827-empty-wallet-with-tokens
danielmain 55c079a
[DDW-827] Addressed PR comments
mchappell 93dd0e2
[DDW-827] updated regex
mchappell 0f84bcc
[DDW-827] updated regex and moved to testable helper method with test…
mchappell 80a2bae
Merge branch 'develop' into feature/ddw-827-empty-wallet-with-tokens
mchappell c9ddad9
[DDW-827] prevent resubmission in the case of error
mchappell e7bad15
[DDW-827] updated unit test and type for helper
mchappell 5ed7eb0
[DDW-827] temporarily removed husky pre-commit
mchappell e3d8ad1
[DDW-827] installed ts packages, and packages required for migration
mchappell e200b09
[DDW-827] converted all javascript files to typescript files
mchappell 66d4797
[DDW-827] converted files returning react components to tsx extension
mchappell a93fb92
[DDW-827] made global replacements in all folders
mchappell d6b1f70
[DDW-827] converted flow style code in typescript files to typescript…
mchappell 63594d4
[DDW-827] added ts-ignore annotations and re-formatted files accordin…
mchappell 127d55c
[DDW-827] updated ts-ignore annotations in components
mchappell b0e766e
[DDW-827] re-enabled husky pre-commit step
mchappell aa50b82
[DDW-827] renamed file extensions
mchappell d29df47
[DDW-827] added ts extensions to prettierignore
mchappell c1f1b73
[DDW-827] Formatted files
mchappell fae0e3c
Merge branch 'develop' into feature/ddw-827-empty-wallet-with-tokens
mchappell 1f00381
[DDW-827] added ts-ignore annotations and re-formatted files accordin…
mchappell 55ac379
[DDW-827] update message translations
mchappell c29fd47
[DDW-827] Update test conditions and minimum ada to remain
mchappell 81a0af9
[DDW-827] updated prettier formatting
mchappell 9ef546a
Merge branch 'develop' into feature/ddw-827-empty-wallet-with-tokens
mchappell b590c6b
[DDW-827] update ts-ignore messsage location
mchappell 00f0fb8
[DDW-827] Update message locations
mchappell c78c937
[DDW-827] fixed lockfile
mchappell 3079744
Merge branch 'develop' into feature/ddw-827-empty-wallet-with-tokens
mchappell c12f159
[DDW-827] updated ts-ignore statement location
mchappell f822a03
[DDW-827] formatted files with prettier
mchappell 71f7e75
[DDW-827] applied prettier formatting
mchappell 2d563f0
[DDW-827] amended error handling to only block send button if specifi…
mchappell 8203be5
[DDW-827] updated typing for localizable error
mchappell c0ca3ee
[DDW-827] reduced ts-ignores in test files
mchappell 6d6efd0
[DDW-827] Removed more ts-ignores
mchappell 7dce134
Merge branch 'develop' into feature/ddw-827-empty-wallet-with-tokens
mchappell 8a2956a
[DDW-827] prevented submission using keyboard if error exists
mchappell 1983413
Merge branch 'feature/ddw-827-empty-wallet-with-tokens' of https://gi…
mchappell 7edda20
[DDW-827] prevented submission using keyboard if form error exists
mchappell 3719798
[DDW-827] updated api thrown error
mchappell 963db65
Merge branch 'develop' into feature/ddw-827-empty-wallet-with-tokens
mchappell 43a2225
Merge branch 'develop' into feature/ddw-827-empty-wallet-with-tokens
c05d7f2
[DDW-827] Code review changes
renanvalentin 71edff6
Merge branch 'develop' into feature/ddw-827-empty-wallet-with-tokens
danielmain 125791b
[DDW-827] Updated CHANGELOG.md and run `yarn manage:translations`
danielmain b2965b3
[DDW-827] Remove ts-ignore
renanvalentin 3f6a5f5
Merge remote-tracking branch 'origin/develop' into feature/ddw-827-em…
szymonmaslowski fee9423
[DDW-827] Update defaultMessages.json file
szymonmaslowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,7 +30,7 @@ export default class Action<Params> { | |
| this.listeners.push(listener); | ||
| } | ||
|
|
||
| trigger(params: Params) { | ||
| trigger(params?: Params) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If this is optional, why not checking it its null the next line? |
||
| this.listeners.forEach((listener) => listener(params)); | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.