Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not repost Greetings after the history #800

Closed
pgrange opened this issue Mar 30, 2023 · 1 comment
Closed

Not repost Greetings after the history #800

pgrange opened this issue Mar 30, 2023 · 1 comment

Comments

@pgrange
Copy link
Contributor

pgrange commented Mar 30, 2023 

          This maybe not so relevant anymore, also the `seq` is a better means to determine old messages. Using `Greetings` was really a work around and we should consider removing it.

Originally posted by @ch1bo in #794 (comment)
@pgrange pgrange mentioned this issue Mar 30, 2023
Merged
4 tasks
@ch1bo ch1bo changed the title This maybe not so relevant anymore, also the seq is a better means to determine old messages. Using Greetings was really a work around and we should consider removing it. Not repost Greetings after the history Mar 31, 2023
@ch1bo
Copy link
Member

ch1bo commented Mar 31, 2023

The Greetings message is used by clients to know about the hydra-node's verification key. Maybe we want to keep it though as that key might have changed from the history? Especially relevant if we would add more more parameters to Greetings from the hydra-node command line options.

@pgrange pgrange closed this as completed Apr 5, 2023
@pgrange pgrange reopened this Apr 5, 2023
@pgrange pgrange closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pgrange @ch1bo