Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

Initial version of the faucet #1

Merged
merged 2 commits into from Sep 12, 2019
Merged

Initial version of the faucet #1

merged 2 commits into from Sep 12, 2019

Conversation

manveru
Copy link
Collaborator

@manveru manveru commented Sep 10, 2019

No description provided.

Copy link
Collaborator

@disassembler disassembler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this going in, just some comments to improve things a little further.

@@ -0,0 +1,26 @@
# A record, from name to path, of the third-party packages
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may want to grab sources.nix from iohk-ops and stick it in here as it gives you a way to point at local repos by updating NIX_PATH var for testing.

@@ -0,0 +1,50 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add iohk-nix (see iohk-ops for how). We can put genesis files/hashes and any other env specific data in there that we can use to key off of. Granted, we're using iohk-ops here so it's not 100% needed but could be useful for end users wanting to run a faucet without iohk-ops. See cardanoLib in there. We'd want to add a jormungandr_testnet attribute with env specific stuff in there.

@manveru manveru merged commit 8b46e13 into master Sep 12, 2019
@manveru manveru deleted the create-faucet branch September 12, 2019 11:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants