WIP: Mockchain properties #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qnikst
force-pushed
the
mockchain-prop
branch
from
e50bbd9
to
9f01539
Compare
qnikst
force-pushed
the
mockchain-prop
branch
from
9f01539
to
49a7d6f
Compare
NicolasDP
approved these changes
Dec 27, 2018
| Ledger { | ||
| unspent_outputs: genesis, | ||
| } | ||
| } |
There was a problem hiding this comment.
actually I would have modified the new() function to take the genesis state. I don't see a reason not to provide the genesis state.
Introduce new tests that can be used for testing any ledger that have required traits implemented. The tests do not require any special properties from the blockchain, other than listed in the blockcfg::properties. More involved tests that care about the structure may be written latter.
qnikst
force-pushed
the
mockchain-prop
branch
from
49a7d6f
to
e852011
Compare
mzabaluev
reviewed
Jan 14, 2019
| @@ -309,6 +321,7 @@ impl std::fmt::Display for Error { | |||
| } | |||
| Error::InvalidSignature(_, _, _) => write!(f, "Input is not signed properly"), | |||
| Error::InvalidTxSignature(_) => write!(f, "Transaction was not signed"), | |||
| Error::TransactionSumIsNonZero(_, _) => write!(f, "Transaction is not zero"), | |||
There was a problem hiding this comment.
The message leaves out the "sum". Could it be named more concisely: NonZeroBalance?
|
code has moved to rust-cardano repo, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress branch, for storing early discussions about the mockchain testing.