Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch block's body only once for transactions in block #1133

Merged
merged 1 commit into from Nov 14, 2019

Conversation

@enzoc4
Copy link
Collaborator

enzoc4 commented Nov 14, 2019

Summary

When paginating transactions in a block, each transaction is fetching the block again, which is noticeable slow if many transactions are requested from a big block.

This addresses one of the bottlenecks causing #1125, it's still not enough to make that query, but it will probably work if the addresses are not requested (only the amounts).

@enzoc4 enzoc4 added the explorer label Nov 14, 2019
@enzoc4 enzoc4 self-assigned this Nov 14, 2019
@enzoc4 enzoc4 marked this pull request as ready for review Nov 14, 2019
@NicolasDP NicolasDP merged commit 6ad72eb into master Nov 14, 2019
6 of 7 checks passed
6 of 7 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
ci/circleci: cargo_audit Your tests passed on CircleCI!
Details
ci/circleci: cargo_fetch Your tests passed on CircleCI!
Details
ci/circleci: rustfmt Your tests passed on CircleCI!
Details
ci/circleci: test_debug Your tests passed on CircleCI!
Details
ci/circleci: test_nightly Your tests passed on CircleCI!
Details
ci/circleci: test_release Your tests passed on CircleCI!
Details
@NicolasDP NicolasDP deleted the explorer-transaction-fetch-block-only-once branch Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.