Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BIP32 key derivation #1136

Merged
merged 1 commit into from Nov 17, 2019
Merged

Implement BIP32 key derivation #1136

merged 1 commit into from Nov 17, 2019

Conversation

@eugene-babichenko
Copy link
Contributor

eugene-babichenko commented Nov 15, 2019

Resolves #450

Copy link
Collaborator

NicolasDP left a comment

thanks

@eugene-babichenko

This comment has been minimized.

Copy link
Contributor Author

eugene-babichenko commented Nov 15, 2019

@NicolasDP @vincenthz Now ed25519-bip32 is imported into jcli. Should I leave it as is, or is it better to make a wrapper for derivation in chain-crypto?

@NicolasDP

This comment has been minimized.

Copy link
Collaborator

NicolasDP commented Nov 17, 2019

No, no need. It's good like this.

@NicolasDP NicolasDP merged commit 7942ae6 into master Nov 17, 2019
6 of 7 checks passed
6 of 7 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci: cargo_audit Your tests passed on CircleCI!
Details
ci/circleci: cargo_fetch Your tests passed on CircleCI!
Details
ci/circleci: rustfmt Your tests passed on CircleCI!
Details
ci/circleci: test_debug Your tests passed on CircleCI!
Details
ci/circleci: test_nightly Your tests passed on CircleCI!
Details
ci/circleci: test_release Your tests passed on CircleCI!
Details
@NicolasDP NicolasDP deleted the bip32-derivation branch Nov 17, 2019
@ilap

This comment has been minimized.

Copy link

ilap commented Nov 23, 2019

Good news. Are you going to implement some master key generation from entropy/seed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.