Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose stake pool parameters #1161

Merged
merged 4 commits into from Nov 21, 2019

Conversation

@enzoc4
Copy link
Collaborator

enzoc4 commented Nov 19, 2019

Implement #1158

Currently all the fields mentioned in that issue are present in the registration certificate, so this adds a way to get the registration certificate from a certain Pool. If those parameters can actually change after the registration, then it may be better to add this fields directly in the pool (but keep them in the certificate)

Like this

{
  stakePool(id: "935f26b40001c2c3b716d865df4d92487262414e26c5cabe3bb6b01bdbba088a") {
    registration {
      serial
      startValidity
      managementThreshold
      owners
      operators
      rewards {
        fixed
        ratio {
          numerator
          denominator
        }
        maxLimit
      }
      rewardAccount
    }
  }
}
enzoc4 added 2 commits Nov 19, 2019
@enzoc4 enzoc4 self-assigned this Nov 19, 2019

/// Reward account
pub fn reward_account(&self, context: &Context) -> Option<String> {
// TODO: What's the best way to show this? As an Address?

This comment has been minimized.

Copy link
@enzoc4

enzoc4 Nov 19, 2019

Author Collaborator

@NicolasDP what do you think of this? reward_account is an AccountIdentifier, but that's not in the graphql API at this moment. Is Address a good type for something like this or should it be something more specific?

@NicolasDP NicolasDP requested a review from input-output-hk/rust Nov 20, 2019
enzoc4 added 2 commits Nov 21, 2019
@enzoc4 enzoc4 marked this pull request as ready for review Nov 21, 2019
@NicolasDP NicolasDP merged commit 4c99a4f into master Nov 21, 2019
5 of 7 checks passed
5 of 7 checks passed
ci/circleci: test_nightly Your tests failed on CircleCI
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci: cargo_audit Your tests passed on CircleCI!
Details
ci/circleci: cargo_fetch Your tests passed on CircleCI!
Details
ci/circleci: rustfmt Your tests passed on CircleCI!
Details
ci/circleci: test_debug Your tests passed on CircleCI!
Details
ci/circleci: test_release Your tests passed on CircleCI!
Details
@NicolasDP NicolasDP deleted the 1158-expose-stake-pool-parameters branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.