Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upExpose stake pool parameters #1161
Conversation
|
|
||
| /// Reward account | ||
| pub fn reward_account(&self, context: &Context) -> Option<String> { | ||
| // TODO: What's the best way to show this? As an Address? |
This comment has been minimized.
This comment has been minimized.
enzoc4
Nov 19, 2019
Author
Collaborator
@NicolasDP what do you think of this? reward_account is an AccountIdentifier, but that's not in the graphql API at this moment. Is Address a good type for something like this or should it be something more specific?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
enzoc4 commentedNov 19, 2019
Implement #1158
Currently all the fields mentioned in that issue are present in the registration certificate, so this adds a way to get the registration certificate from a certain Pool. If those parameters can actually change after the registration, then it may be better to add this fields directly in the pool (but keep them in the certificate)
Like this
{ stakePool(id: "935f26b40001c2c3b716d865df4d92487262414e26c5cabe3bb6b01bdbba088a") { registration { serial startValidity managementThreshold owners operators rewards { fixed ratio { numerator denominator } maxLimit } rewardAccount } } }