Skip to content

Update transaction building api #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 8, 2019
Merged

Update transaction building api #84

merged 4 commits into from
Nov 8, 2019

Conversation

@ecioppettini
Copy link
Contributor

@ecioppettini ecioppettini commented Nov 7, 2019 •
edited
Loading

Rewrite TransactionBuilder to the new API.

  • The new TransactionBuilder is also a state machine. As generics can't be directly exposed, it's mapped to four different types.
  • Add DelegationType for StakeDelegation certificate. (Should also cover Expose Ratio Stake #81 )
  • Add payload signing for all the certificate types.

Enzo Cioppettini added 3 commits November 7, 2019 11:13
@ecioppettini ecioppettini added WIP Work in progress (do not merge) breaking changes labels Nov 7, 2019
@ecioppettini ecioppettini self-assigned this Nov 7, 2019
@ecioppettini ecioppettini mentioned this pull request Nov 8, 2019
Merged
@ecioppettini ecioppettini marked this pull request as ready for review November 8, 2019 18:04
@ecioppettini ecioppettini removed the WIP Work in progress (do not merge) label Nov 8, 2019
@NicolasDP NicolasDP merged commit 2a80e70 into master Nov 8, 2019
@NicolasDP NicolasDP deleted the update-transaction-building-api branch November 8, 2019 18:31
@ecioppettini ecioppettini mentioned this pull request Nov 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasDP NicolasDP Awaiting requested review from NicolasDP

@vincenthz vincenthz Awaiting requested review from vincenthz

Assignees

@ecioppettini ecioppettini

Labels

breaking changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ecioppettini @NicolasDP