From f496adce61f9022c87e19cb9c2f2ae63941945a7 Mon Sep 17 00:00:00 2001 From: wklos-iohk Date: Tue, 16 Apr 2024 12:04:40 +0200 Subject: [PATCH] test(extension): update after code review --- .../src/assert/multidelegation/MultidelegationPageAssert.ts | 2 +- .../src/elements/multidelegation/MultidelegationPage.ts | 2 +- .../src/features/MultiDelegationPageExtended.part1.feature | 2 +- .../src/features/MultiDelegationPageExtended.part2.feature | 3 +-- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/e2e-tests/src/assert/multidelegation/MultidelegationPageAssert.ts b/packages/e2e-tests/src/assert/multidelegation/MultidelegationPageAssert.ts index 936bef8b69..e38af3f713 100644 --- a/packages/e2e-tests/src/assert/multidelegation/MultidelegationPageAssert.ts +++ b/packages/e2e-tests/src/assert/multidelegation/MultidelegationPageAssert.ts @@ -321,7 +321,7 @@ class MultidelegationPageAssert { await MultidelegationPage.waitForPoolsCounterToBeGreaterThanZero(); poolLimit ??= await MultidelegationPage.getNumberOfPoolsFromCounter(); if (stakePoolsDisplayType === 'cards') { - // TODO: add code to handle grid cards + // TODO: add code to handle grid cards - LW-10284 throw new Error('Please add validation for grid cards sorting'); } else { const columnContent = await MultidelegationPage.extractColumnContent( diff --git a/packages/e2e-tests/src/elements/multidelegation/MultidelegationPage.ts b/packages/e2e-tests/src/elements/multidelegation/MultidelegationPage.ts index 4df0a08aa6..7c738530d5 100644 --- a/packages/e2e-tests/src/elements/multidelegation/MultidelegationPage.ts +++ b/packages/e2e-tests/src/elements/multidelegation/MultidelegationPage.ts @@ -590,7 +590,7 @@ class MultidelegationPage { async getNumberOfPoolsFromCounter(): Promise { const poolsCounterText = await this.poolsCounter.getText(); - return Number(poolsCounterText.replace('Pools (', '').replace(',', '').replace(')', '')); + return Number(Number(poolsCounterText.replace(/.*\(/, '').replace(')', '').replace(',', ''))); } async waitForPoolsCounterToBeGreaterThanZero(): Promise { diff --git a/packages/e2e-tests/src/features/MultiDelegationPageExtended.part1.feature b/packages/e2e-tests/src/features/MultiDelegationPageExtended.part1.feature index 51848b2692..335fc12440 100644 --- a/packages/e2e-tests/src/features/MultiDelegationPageExtended.part1.feature +++ b/packages/e2e-tests/src/features/MultiDelegationPageExtended.part1.feature @@ -88,7 +88,7 @@ Feature: Staking Page - Extended View Then I see the Network Info component with the expected content @LW-8499 @Testnet @Mainnet - Scenario: Extended View - Staking - Show tooltip for column in browse pools section + Scenario: Extended View - Staking - Show tooltip for columns in browse pools section When I navigate to Staking extended page And I open Browse pools tab And I switch to list view on "Browse pools" tab diff --git a/packages/e2e-tests/src/features/MultiDelegationPageExtended.part2.feature b/packages/e2e-tests/src/features/MultiDelegationPageExtended.part2.feature index 0a4f9e8766..b1975ca611 100644 --- a/packages/e2e-tests/src/features/MultiDelegationPageExtended.part2.feature +++ b/packages/e2e-tests/src/features/MultiDelegationPageExtended.part2.feature @@ -10,7 +10,7 @@ Feature: Staking Page - Extended View And I open Browse pools tab Then "More options" component with stake pool sorting options is displayed - @LW-10139 @LW-1041 @LW-10142 @Testnet @Mainnet + @LW-10139 @LW-10141 @LW-10142 @Testnet @Mainnet Scenario: Extended View - Staking - List View - Stake pool list sorting by ticker (default) When I am on Staking extended page And I open Browse pools tab @@ -49,4 +49,3 @@ Feature: Staking Page - Extended View | Blocks | descending | ascending | | Pledge | descending | ascending | | Live Stake | descending | ascending | -# | Ticker | ascending | descending |# Tested in LW-10139