From ff8b9c62afc412a9de0abf2590a3bfcf64832682 Mon Sep 17 00:00:00 2001 From: vetalcore Date: Wed, 17 Jul 2024 15:39:57 +0300 Subject: [PATCH] fix(extension): resolved pr comments --- .../creation-flow/ShareWalletDetails/utils.ts | 4 ++-- .../docs/schema/shared-wallet-type-autogenerated.ts | 7 +++---- packages/staking/src/features/Drawer/SignConfirmation.tsx | 1 + 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/core/src/shared-wallets/add-shared-wallet/creation-flow/ShareWalletDetails/utils.ts b/packages/core/src/shared-wallets/add-shared-wallet/creation-flow/ShareWalletDetails/utils.ts index 78e5baf2c..ce611f789 100644 --- a/packages/core/src/shared-wallets/add-shared-wallet/creation-flow/ShareWalletDetails/utils.ts +++ b/packages/core/src/shared-wallets/add-shared-wallet/creation-flow/ShareWalletDetails/utils.ts @@ -54,9 +54,9 @@ const mapStateToSchema = (state: CreationFlowState): SharedWalletSchema => { return { metadata: { - participants: coSigners.map((coSigner) => ({ + coSigners: coSigners.map((coSigner) => ({ name: coSigner.name, - publicKey: coSigner.sharedWalletKey, + sharedWalletKey: coSigner.sharedWalletKey, })), sharedWalletName: walletName || '', }, diff --git a/packages/core/src/shared-wallets/docs/schema/shared-wallet-type-autogenerated.ts b/packages/core/src/shared-wallets/docs/schema/shared-wallet-type-autogenerated.ts index 98c24a5ed..e2c7462bc 100644 --- a/packages/core/src/shared-wallets/docs/schema/shared-wallet-type-autogenerated.ts +++ b/packages/core/src/shared-wallets/docs/schema/shared-wallet-type-autogenerated.ts @@ -25,17 +25,16 @@ export interface SharedWalletSchema { /** * The list of participants in the shared wallet */ - // TDOO; rename to CoSigners - participants: { + coSigners: { [k: string]: unknown; /** * The name of the participant */ name: string; /** - * The Ed25519KeyHash of the participant + * The Bip32PublicKeyHex of the participant */ - publicKey: string; + sharedWalletKey: string; }[]; /** * The name of the shared wallet diff --git a/packages/staking/src/features/Drawer/SignConfirmation.tsx b/packages/staking/src/features/Drawer/SignConfirmation.tsx index 9f526ca48..136ba44cc 100644 --- a/packages/staking/src/features/Drawer/SignConfirmation.tsx +++ b/packages/staking/src/features/Drawer/SignConfirmation.tsx @@ -101,6 +101,7 @@ export const SignConfirmationFooter = (): ReactElement => { const signedTx = await delegationTxBuilder.build().sign(); if (isSharedWallet && sharedKey) { + // TODO: integrate with tx summary drawer LW-10970 exportMultisigTransaction(signedTx, sharedKey, currentChain); } else { await inMemoryWallet.submitTx(signedTx);