[KAIZEN] Turn some warnings into errors #1079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print summaries for the remaining ones
build.sbt
Outdated
| // https://www.scala-lang.org/2021/01/12/configuring-and-suppressing-warnings.html | ||
| // cat={warning-name}:ws prints a summary with the number of warnings of the given type | ||
| // any:e turns all remaining warnings into errors | ||
| "-Wconf:cat=deprecation:ws,cat=lint-package-object-classes:ws,cat=unused:ws,cat=lint-infer-any:ws,cat=lint-byname-implicit:ws,cat=other-match-analysis:ws,any:e", |
There was a problem hiding this comment.
We should aim to gradually make the list of cat={}:ws thinner
There was a problem hiding this comment.
I think it's great to reduce the noise during dev. I think a way to make it display the full warning easily would be useful though. Something like an env var (but maybe there is a more elegant way):
Suggested change
| "-Wconf:cat=deprecation:ws,cat=lint-package-object-classes:ws,cat=unused:ws,cat=lint-infer-any:ws,cat=lint-byname-implicit:ws,cat=other-match-analysis:ws,any:e", | |
| if (sys.env.get("MANTIS_FULL_WARNS").contains("true")) | |
| "" | |
| else | |
| "-Wconf:cat=deprecation:ws,cat=lint-package-object-classes:ws,cat=unused:ws,cat=lint-infer-any:ws,cat=lint-byname-implicit:ws,cat=other-match-analysis:ws,any:e", |
usage: MANTIS_FULL_WARNS=true sbt compile
There was a problem hiding this comment.
Sounds good, but I would be explicit and put "-Wconf:any:w" in there
Retain old settings for Compile/doc (otherwise derivation build fails in buildkite)
AurelienRichez
approved these changes
Jul 28, 2021
dzajkowski
approved these changes
Jul 28, 2021
lukasz-golebiewski
force-pushed
the
kaizen/deal-with-the-warnings
branch
from
ece68a2
to
6999867
Compare
|
Closing in favor of #1081 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.