Navigation Menu

Skip to content

Commit

Permalink
Update the comment on the list of properties
Browse files Browse the repository at this point in the history
  • Loading branch information
dcoutts authored and coot committed May 12, 2021
1 parent 0d678fb commit 79d3eac
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions ouroboros-network/test/Test/Ouroboros/Network/PeerSelection.hs
Expand Up @@ -125,6 +125,10 @@ tests =
-- into a busy cycle. See also the "no excessive busyness" property for a
-- more advanced version.
--
-- * A "no excessive busyness" property. This checks that the governor does not
-- remain too busy for too long. It's quite easy to write bugs that don't
-- cause the governor to fail, but cause it to go into fairly-busy cycles.
--
-- * A state consistency property that the governor's view of part of the state
-- and the "true" state of the mock environment are maintained in an
-- appropriate correspondence.
Expand All @@ -136,31 +140,27 @@ tests =
-- * A cold peer gossip "reachable" property: that the governor either hits
-- its target for the number of cold peers, or finds all the reachable peers.
--
-- Properties that we would like to have:
-- * A known peer target progress property: that the governor makes progress
-- within a bounded time towards its known peers target, from below and above.
--
-- * A "no excessive busyness" property. This checks that the governor does not
-- remain too busy for too long. It's quite easy to write bugs that don't
-- cause the governor to fail, but cause it to go into fairly-busy cycles.
-- * An established peer target property: the same as above but for established
-- peers.
--
-- * An active peer target property: the same as above but for active peers.
--
-- Properties that we would like to have:
--
-- * A public root peers target property: that the governor hits its target for
-- for the number of public root peers (or as near as possible), and does
-- note "grossly" overshoot. Since the public roots is a one sided target, but
-- we don't want to overshoot excessively.
--
-- * A warm peer target property: that the governor hits its established peers
-- target (or as near as possible).
--
-- * A hot peer target property: that the governor hits its active peers
-- target (or as near as possible).
--
-- * A local root peers target property: that the governor hits it target for
-- getting all its local root peers into the established state, and a target
-- number of them into the active state (or as near as possible).
--
-- Other properties we might like to think about
--
-- * for vaguely stable envs, we do stablise at our target number of cold peers
-- * time to stabilise after a change is not crazy
-- * time to find new nodes after a graph change is ok
-- * targets or root peer set dynamic

Expand Down

0 comments on commit 79d3eac

Please sign in to comment.