Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split SimArgs in Diffusion simulation #3905

Closed
coot opened this issue Jul 15, 2022 · 0 comments · Fixed by #4004
Closed

Split SimArgs in Diffusion simulation #3905

coot opened this issue Jul 15, 2022 · 0 comments · Fixed by #4004
Assignees
@bolt12
Labels
diffusion Issues / PRs related to diffusion layer technical debt

Comments

@coot
Copy link
Contributor

coot commented Jul 15, 2022

We ought to split SimArgs into two parts:

  • SimArgs which only contains simulation level configuration,
  • NodeArgs which only contains node level configuration

and then redefine

data DiffusionScript = DiffsionScript SimArgs [(NodeArgs, [Command])]
@coot coot added networking diffusion Issues / PRs related to diffusion layer technical debt labels Jul 15, 2022
@bolt12 bolt12 self-assigned this Jul 15, 2022
@coot coot removed the tech-debt-h2 label Aug 2, 2022
@bolt12 bolt12 mentioned this issue Sep 13, 2022
Merged
9 tasks
iohk-bors bot added a commit that referenced this issue Oct 19, 2022
@iohk-bors @bolt12
Merge #4004
c5efabb 
4004: Refactored DiffusionScript r=bolt12 a=bolt12

# Description

This PR fixes #3905 



Co-authored-by: Armando Santos <armando@well-typed.com>
iohk-bors bot added a commit that referenced this issue Oct 19, 2022
@iohk-bors @bolt12
Merge #4004
075c608 
4004: Refactored DiffusionScript r=coot a=bolt12

# Description

This PR fixes #3905 



Co-authored-by: Armando Santos <armando@well-typed.com>
@iohk-bors iohk-bors bot closed this as completed in 2dc7a64 Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bolt12 bolt12

Labels
diffusion Issues / PRs related to diffusion layer technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactored DiffusionScript IntersectMBO/ouroboros-network
2 participants
@coot @bolt12