Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Show (Header blk) constraint to RunDemo #741

Merged
merged 1 commit into from Jul 12, 2019
Merged

Conversation

coot
Copy link
Contributor

@coot coot commented Jul 11, 2019

It would be better to provide Condense instances for data structures
defined in ouroboros-network, or move condense class to
ouroboros-network (or an independent package). Either way we should be
able to remove the Show constraints and use Condense instead which give
better debugging experience.

It would be better to provide Condense instances for data structures
defined in ouroboros-network, or move condense class to
ouroboros-network (or an independent package).  Either way we should be
able to remove the Show constraints and use Condense instead which give
better debugging experience.
@coot coot requested a review from mrBliss July 11, 2019 21:44
Copy link
Contributor

@mrBliss mrBliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the TODO

@mrBliss mrBliss merged commit 82322b9 into master Jul 12, 2019
@iohk-bors iohk-bors bot deleted the coot/run-demo-show branch July 12, 2019 06:14
@mrBliss mrBliss added the consensus issues related to ouroboros-consensus label Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus issues related to ouroboros-consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants