Provision GHC that corresponds to stack LTS #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmitchell
approved these changes
Jan 31, 2018
Contributor
|
The CI job timed out. Can you ensure the CI script passes locally before merging? |
Open
puffnfresh
approved these changes
Jan 31, 2018
puffnfresh
reviewed
Jan 31, 2018
src/Stack2nix/Util.hs
Outdated
| -- given nixAttr, build it and add $out/bin to $PATH | ||
| ensureExecutable :: String -> IO () | ||
| ensureExecutable nixAttr = do | ||
| (exitcode2, stdout, err2) <- readProcessWithExitCode "nix-build" ["-A", nixAttr, "<nixpkgs>"] mempty |
Contributor
There was a problem hiding this comment.
Should this have --no-build-output?
Contributor
Author
|
@jmitchell turns out CI failed due to stack2nix.nix being outdated. |
Contributor
Author
|
It works now - but very close to travis-ci time limit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.