From fd6d8ba75f5ff72e630e72f9d0ec12e4b7e64119 Mon Sep 17 00:00:00 2001 From: Jesse Wright <63333554+jeswr@users.noreply.github.com> Date: Wed, 21 Jun 2023 22:17:06 +1000 Subject: [PATCH 1/3] breaking: remove year from license header --- eslint-configs/eslint-config-base/license-header.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eslint-configs/eslint-config-base/license-header.js b/eslint-configs/eslint-config-base/license-header.js index d0cd8991..9e3a41ff 100644 --- a/eslint-configs/eslint-config-base/license-header.js +++ b/eslint-configs/eslint-config-base/license-header.js @@ -1,5 +1,5 @@ // -// Copyright 2023 Inrupt Inc. +// Copyright Inrupt Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal in From 70f672138ba83e40620b4d97da05bd13c167f7a0 Mon Sep 17 00:00:00 2001 From: Jesse Wright <63333554+jeswr@users.noreply.github.com> Date: Wed, 21 Jun 2023 22:17:37 +1000 Subject: [PATCH 2/3] breaking: enforce use of type-imports where possible --- eslint-configs/eslint-config-lib/index.js | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/eslint-configs/eslint-config-lib/index.js b/eslint-configs/eslint-config-lib/index.js index 9d3c8cc4..a4a49118 100644 --- a/eslint-configs/eslint-config-lib/index.js +++ b/eslint-configs/eslint-config-lib/index.js @@ -58,6 +58,22 @@ module.exports = { // Use typescript's definition checker "no-use-before-define": ["off"], "@typescript-eslint/no-use-before-define": ["warn"], + + // Ensure that type only imports are used whenever possible; this is also important + // to avoid violating the import/no-unresolved rule when type-only packages such as + // @rdfjs/types are used + // + // For instance if we have: + // ```ts + // import { Term } from '@rdfjs/types'; + // ``` + // Then the import/no-unresolved rule is violated; but eslint --fix is unable to resolve + // the problem. By adding this rule eslint --fix is able to set this to: + // ```ts + // import type { Term } from '@rdfjs/types'; + // ``` + // + "@typescript-eslint/consistent-type-imports": ["error", { prefer: "type-imports" }], }, }, ], From a6cea68238e08c04af8584096ef66cd7858da682 Mon Sep 17 00:00:00 2001 From: Jesse Wright <63333554+jeswr@users.noreply.github.com> Date: Wed, 21 Jun 2023 22:21:10 +1000 Subject: [PATCH 3/3] chore: remove year from license headers --- e2e/browser/test-app/components/appContainer/index.tsx | 2 +- e2e/browser/test-app/components/solidClient/index.tsx | 2 +- e2e/browser/test-app/pages/_app.tsx | 2 +- e2e/browser/test-app/pages/index.tsx | 2 +- e2e/browser/test/e2e.playwright.ts | 2 +- e2e/browser/test/globalSetup.ts | 2 +- eslint-configs/eslint-config-base/index.js | 2 +- eslint-configs/eslint-config-lib/index.js | 2 +- eslint-configs/eslint-config-react/index.js | 2 +- packages/internal-playwright-helpers/src/flows/auth.ts | 2 +- packages/internal-playwright-helpers/src/index.ts | 2 +- packages/internal-playwright-helpers/src/pages/cognito.ts | 2 +- packages/internal-playwright-helpers/src/pages/open-id.ts | 2 +- packages/internal-playwright-helpers/src/pages/testPage.ts | 2 +- packages/internal-test-env/index.ts | 2 +- packages/internal-test-env/utils.ts | 2 +- packages/jest-jsdom-polyfills/index.js | 2 +- playwright.config.ts | 2 +- 18 files changed, 18 insertions(+), 18 deletions(-) diff --git a/e2e/browser/test-app/components/appContainer/index.tsx b/e2e/browser/test-app/components/appContainer/index.tsx index 2d2930ac..c9f0fc0e 100644 --- a/e2e/browser/test-app/components/appContainer/index.tsx +++ b/e2e/browser/test-app/components/appContainer/index.tsx @@ -1,5 +1,5 @@ // -// Copyright 2022 Inrupt Inc. +// Copyright Inrupt Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal in diff --git a/e2e/browser/test-app/components/solidClient/index.tsx b/e2e/browser/test-app/components/solidClient/index.tsx index 68cc6360..8cb236f3 100644 --- a/e2e/browser/test-app/components/solidClient/index.tsx +++ b/e2e/browser/test-app/components/solidClient/index.tsx @@ -1,5 +1,5 @@ // -// Copyright 2022 Inrupt Inc. +// Copyright Inrupt Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal in diff --git a/e2e/browser/test-app/pages/_app.tsx b/e2e/browser/test-app/pages/_app.tsx index b3f806e5..09e15661 100644 --- a/e2e/browser/test-app/pages/_app.tsx +++ b/e2e/browser/test-app/pages/_app.tsx @@ -1,5 +1,5 @@ // -// Copyright 2022 Inrupt Inc. +// Copyright Inrupt Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal in diff --git a/e2e/browser/test-app/pages/index.tsx b/e2e/browser/test-app/pages/index.tsx index 5c706f3f..91b9e812 100644 --- a/e2e/browser/test-app/pages/index.tsx +++ b/e2e/browser/test-app/pages/index.tsx @@ -1,5 +1,5 @@ // -// Copyright 2022 Inrupt Inc. +// Copyright Inrupt Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal in diff --git a/e2e/browser/test/e2e.playwright.ts b/e2e/browser/test/e2e.playwright.ts index 2aefbd9e..71ab28fe 100644 --- a/e2e/browser/test/e2e.playwright.ts +++ b/e2e/browser/test/e2e.playwright.ts @@ -1,5 +1,5 @@ // -// Copyright 2022 Inrupt Inc. +// Copyright Inrupt Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal in diff --git a/e2e/browser/test/globalSetup.ts b/e2e/browser/test/globalSetup.ts index a1260c75..ca048a96 100644 --- a/e2e/browser/test/globalSetup.ts +++ b/e2e/browser/test/globalSetup.ts @@ -1,5 +1,5 @@ // -// Copyright 2022 Inrupt Inc. +// Copyright Inrupt Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal in diff --git a/eslint-configs/eslint-config-base/index.js b/eslint-configs/eslint-config-base/index.js index 3dfa357b..f2923d94 100644 --- a/eslint-configs/eslint-config-base/index.js +++ b/eslint-configs/eslint-config-base/index.js @@ -1,5 +1,5 @@ /* -Copyright 2020 Inrupt Inc. +Copyright Inrupt Inc. Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in diff --git a/eslint-configs/eslint-config-lib/index.js b/eslint-configs/eslint-config-lib/index.js index a4a49118..42cea63b 100644 --- a/eslint-configs/eslint-config-lib/index.js +++ b/eslint-configs/eslint-config-lib/index.js @@ -1,5 +1,5 @@ /* -Copyright 2020 Inrupt Inc. +Copyright Inrupt Inc. Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in diff --git a/eslint-configs/eslint-config-react/index.js b/eslint-configs/eslint-config-react/index.js index 12fe1341..52b70097 100644 --- a/eslint-configs/eslint-config-react/index.js +++ b/eslint-configs/eslint-config-react/index.js @@ -1,5 +1,5 @@ /* -Copyright 2020 Inrupt Inc. +Copyright Inrupt Inc. Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in diff --git a/packages/internal-playwright-helpers/src/flows/auth.ts b/packages/internal-playwright-helpers/src/flows/auth.ts index e72bf888..9a69206d 100644 --- a/packages/internal-playwright-helpers/src/flows/auth.ts +++ b/packages/internal-playwright-helpers/src/flows/auth.ts @@ -1,5 +1,5 @@ // -// Copyright 2022 Inrupt Inc. +// Copyright Inrupt Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal in diff --git a/packages/internal-playwright-helpers/src/index.ts b/packages/internal-playwright-helpers/src/index.ts index f3b492de..65232368 100644 --- a/packages/internal-playwright-helpers/src/index.ts +++ b/packages/internal-playwright-helpers/src/index.ts @@ -1,5 +1,5 @@ // -// Copyright 2022 Inrupt Inc. +// Copyright Inrupt Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal in diff --git a/packages/internal-playwright-helpers/src/pages/cognito.ts b/packages/internal-playwright-helpers/src/pages/cognito.ts index 510729d9..04242fee 100644 --- a/packages/internal-playwright-helpers/src/pages/cognito.ts +++ b/packages/internal-playwright-helpers/src/pages/cognito.ts @@ -1,5 +1,5 @@ // -// Copyright 2022 Inrupt Inc. +// Copyright Inrupt Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal in diff --git a/packages/internal-playwright-helpers/src/pages/open-id.ts b/packages/internal-playwright-helpers/src/pages/open-id.ts index 9f621592..8304ee8a 100644 --- a/packages/internal-playwright-helpers/src/pages/open-id.ts +++ b/packages/internal-playwright-helpers/src/pages/open-id.ts @@ -1,5 +1,5 @@ // -// Copyright 2022 Inrupt Inc. +// Copyright Inrupt Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal in diff --git a/packages/internal-playwright-helpers/src/pages/testPage.ts b/packages/internal-playwright-helpers/src/pages/testPage.ts index 07bb4db1..dc3e1258 100644 --- a/packages/internal-playwright-helpers/src/pages/testPage.ts +++ b/packages/internal-playwright-helpers/src/pages/testPage.ts @@ -1,5 +1,5 @@ // -// Copyright 2022 Inrupt Inc. +// Copyright Inrupt Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal in diff --git a/packages/internal-test-env/index.ts b/packages/internal-test-env/index.ts index 4cdb3006..75a7fa2f 100644 --- a/packages/internal-test-env/index.ts +++ b/packages/internal-test-env/index.ts @@ -1,5 +1,5 @@ // -// Copyright 2022 Inrupt Inc. +// Copyright Inrupt Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal in diff --git a/packages/internal-test-env/utils.ts b/packages/internal-test-env/utils.ts index 3431fe4f..cef8cbc4 100644 --- a/packages/internal-test-env/utils.ts +++ b/packages/internal-test-env/utils.ts @@ -1,5 +1,5 @@ // -// Copyright 2022 Inrupt Inc. +// Copyright Inrupt Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal in diff --git a/packages/jest-jsdom-polyfills/index.js b/packages/jest-jsdom-polyfills/index.js index ac0d5cef..087b7f42 100644 --- a/packages/jest-jsdom-polyfills/index.js +++ b/packages/jest-jsdom-polyfills/index.js @@ -1,5 +1,5 @@ // -// Copyright 2022 Inrupt Inc. +// Copyright Inrupt Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal in diff --git a/playwright.config.ts b/playwright.config.ts index c14ae308..fa8dd0a8 100644 --- a/playwright.config.ts +++ b/playwright.config.ts @@ -1,5 +1,5 @@ // -// Copyright 2022 Inrupt Inc. +// Copyright Inrupt Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal in